Re: [patch] usb video class support

On 3/20/07, Paulo Marques <[email protected]> wrote:
> Ragner Magalhaes wrote:
> > [...]
> > +
> > +#ifndef __LINUX_USB_VIDEO_H
> > +#define __LINUX_USB_VIDEO_H
> > +
>
> >[...]
>
> > +#define USB_VC_HEADER_SIZE(n)                (12+(n))
> > +
> > +/* As above, but more useful for defining your own descriptors: */
> > +#define DECLARE_USB_VC_HEADER_DESCRIPTOR(n)                  \
> > +struct usb_vc_header_descriptor_##n {                                \
> > +     __u8  bLength;                                          \
> > +     __u8  bDescriptorType;                                  \
> > +     __u8  bDescriptorSubtype;                               \
> > +     __le16 bcdUVC;                                          \
> > +     __le16 wTotalLength;                                    \
> > +     __le32 dwClockFrequency;                                \
> > +     __u8  bInCollection;                                    \
> > +     __u8  baInterfaceNr[n];                                 \
> > +} __attribute__ ((packed))
> > +
> > +#endif
>     ^^^^^^
>
> I just noticed this: why is everything below this point declared outside
> "#ifndef __LINUX_USB_VIDEO_H" ?
>
> That will produce double definitions if "linux/usb/video.h" is included
> more than once, no?
Sorry, fixing ...
>
> --
> Paulo Marques - www.grupopie.com
>
> "Prediction is hard. Especially of the future."
> Niels Bohr
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> [email protected]
> To unsubscribe, use the last form field at:
> https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
>


-- 
Ragner N Magalhães

Instituto Nokia de Tecnologia - INdT
Open Source Mobile Research Center - OSMRC
Linux Kernel Team

Tel:       (+55 92) 2126 1046
Mobile: (+55 92) 8143 2869

E-mail: [email protected]
            [email protected]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel