Re: [Bugme-new] [Bug 8297] New: ldusb returns bad data on subsequent reads if no data is available.

Am Donnerstag, 5. April 2007 06:41 schrieb Shawn Bohrer:
> On 4/4/07, Oliver Neukum <[email protected]> wrote:
> 
> > +       spin_lock(&dev->rbsl);
> >         if (urb->actual_length > 0) {
> >                 next_ring_head = (dev->ring_head+1) % ring_buffer_size;
> >                 if (next_ring_head != dev->ring_tail) {
> > @@ -245,17 +249,20 @@
> >                         dev_warn(&dev->intf->dev,
> >                                  "Ring buffer overflow, %d bytes dropped\n",
> >                                  urb->actual_length);
> > +                       dev->buffer_overflow = 1;
> >         }
> 
> It looks like you are missing brackets around the else case.

Which else case?

> This patch does seem to fix the problem I described, though admittedly
> I haven't exactly figured out how you are supposed to use the ldusb

I have no idea how to use the device. Sorry.

	Regards
		Oliver

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel