Re: [PATCH 2/2] USB: add OTG mode support to Freescale EHCI driver

On Monday 05 February 2007 12:24 am, Li Yang wrote:
> Add FSL_USB2_DR_OTG mode support to ehci-fsl driver.
> 
> Signed-off-by: Li Yang <[email protected]>


I guess I don't see any point to this patch.  There's no support
for any dual-role functionality, is there?  Nothing senses any
ID-pin in a register, to set usb_bus.is_b_host ... nothing even
sets usb_bus.otg_port, or does anything when HNP would kick in.

In short, the most this seems to do is allow the pure-host mode
to operate on a board with a Mini-AB connector ... there's still
nothing related to dual-role driver support.

If that's so, then please correct the patch comments, and also
add something similar to the code ... saying the driver still
only supports a single role, and has no OTG features, though it
will let a pure host mode come up on the Mini-AB connector.

- Dave



> 
> ---
> 
>  drivers/usb/host/ehci-fsl.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index 1a915e9..8d90017 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -67,7 +67,8 @@ int usb_hcd_fsl_probe(const struct hc_driver *driver,
>  	 * in host mode.
>  	 */
>  	if (!((pdata->operating_mode == FSL_USB2_DR_HOST) ||
> -	      (pdata->operating_mode == FSL_USB2_MPH_HOST))) {
> +	      (pdata->operating_mode == FSL_USB2_MPH_HOST) ||
> +	      (pdata->operating_mode == FSL_USB2_DR_OTG))) {
>  		dev_err(&pdev->dev,
>  			"Non Host Mode configured for %s. Wrong driver linked.\n",
>  			pdev->dev.bus_id);
> @@ -193,7 +194,8 @@ static void mpc83xx_usb_setup(struct usb_hcd *hcd)
>  	out_be32(non_ehci + FSL_SOC_USB_CTRL, 0x00000004);
>  	out_be32(non_ehci + FSL_SOC_USB_SNOOP1, 0x0000001b);
>  
> -	if (pdata->operating_mode == FSL_USB2_DR_HOST)
> +	if ((pdata->operating_mode == FSL_USB2_DR_HOST) ||
> +			(pdata->operating_mode == FSL_USB2_DR_OTG))
>  		mpc83xx_setup_phy(ehci, pdata->phy_mode, 0);
>  
>  	if (pdata->operating_mode == FSL_USB2_MPH_HOST) {
> 

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel