Re: [PATCH 006/149] USB: m66592-udc: peripheral controller driver for M66592

David Brownell wrote:
> > >
> > > Here's the all-rolled-up patch ... if you sign off on the whole
> > > thing, then I expect it should go upstream ASAP.
> >
> > I made the patch which fixed a problem pointed out in LKML.
> >  - fixed memory leak
> >  - change ep0_buf
> >  - fixed byteswapping
>
> It doesn't fix the probe() path which returns after error
> without unregistering the IRQ handler, though ... a leak,
> but not a memory leak.

Thank you for your comment. I made the patch.

Thanks,
Y.Shimoda

---
 drivers/usb/gadget/m66592-udc.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- linux-2.6.org/drivers/usb/gadget/m66592-udc.c	2007-07-17 11:04:03.000000000 +0900
+++ linux-2.6/drivers/usb/gadget/m66592-udc.c	2007-07-17 11:04:45.000000000 +0900
@@ -1589,7 +1589,7 @@ static int __init m66592_probe(struct pl

 	m66592->ep0_req = m66592_alloc_request(&m66592->ep[0].ep, GFP_KERNEL);
 	if (m66592->ep0_req == NULL)
-		goto clean_up;
+		goto clean_up2;
 	m66592->ep0_req->complete = nop_completion;

 	init_controller(m66592);
@@ -1597,6 +1597,8 @@ static int __init m66592_probe(struct pl
 	dev_info(&pdev->dev, "version %s\n", DRIVER_VERSION);
 	return 0;

+clean_up2:
+	free_irq(irq, m66592);
 clean_up:
 	if (m66592) {
 		if (m66592->ep0_req)


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel