Re: [PATCH 006/149] USB: m66592-udc: peripheral controller driver for M66592
Greg KH <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jul 16, 2007 at 01:27:49PM -0700, David Brownell wrote: > On Sunday 15 July 2007, Yoshihiro Shimoda wrote: > > David Brownell wrote: > > > On Saturday 14 July 2007, Yoshihiro Shimoda wrote: > > > > > Does the following patch behave, with all the locking test > > > > > options in the kernel debug menu enabled? > > > > > > > > I applied this patch and I tested on following kernel debug > > > > menu enabled. > > > > - CONFIG_DEBUG_MUTEXES > > > > - CONFIG_DEBUG_SPINLOCK > > > > - CONFIG_DEBUG_LOCK_ALLOC > > > > - CONFIG_DEBUG_SPINLOCK_SLEEP > > > > - CONFIG_PROVE_LOCKING > > > > When I tested CONFIG_DEBUG_LOCKDEP enabled, A kernel did not > > > > boot at all in my development environment... > > > > > > Whoops! That needs fixing. :( > > > > I try fixing this problem. > > It's rather far afield from USB! > > > > > > > Here's the all-rolled-up patch ... if you sign off on the whole > > > thing, then I expect it should go upstream ASAP. > > > > I made the patch which fixed a problem pointed out in LKML. > > - fixed memory leak > > - change ep0_buf > > - fixed byteswapping > > It doesn't fix the probe() path which returns after error > without unregistering the IRQ handler, though ... a leak, > but not a memory leak. > > > > Should I submit an email to LKML and linux-usb-devel mailing list > > after having made a thing including all-rolled-up patch? > > Unfortunately Linus merged a partial fix yesterday ... rather > than the more complete update which predated it. (Sigh). > > Greg, do you have a suggestion about how to resolve this mess? > Unfortunately it seems Linus isn't taking patches direct from > me lately... Can the both of you agree on a patch that solves the needed issues for this driver and send it to me? I've seen too many patches on this thread to be able to determine what is correct :) thanks, greg k-h ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel