Re: Questions about the r8a66597-hcd driver

Hi, Alan

Alan Stern wrote:
 > I have three questions about your r8a66597-hcd driver.  First, is there
 > any reason for done() and finish_request() to be separate routines?
 > They do exactly the same thing.

The reason for separate routines is use or nonuse of the __releases()
and __acquires(). But I made a mistake in how to use it...

 > Second, in packet_read() is there some reason you don't check for
 > -EOVERFLOW errors?

Oh, I did not know it.
The m66592-udc has a similar problem, so I will try to fix this problem.

 > Third, also in packet_read(), this test:
 >
 > 	if ((size % td->maxpacket) > 0) {
 >
 > seems wrong.  You're trying to detect a short packet, but the test will
 > give the wrong answer if size is 0.

Thank you for your pointing out my mistake.

 > Does this patch look okay to you?

Yes, I applied this patch and confirmed it is working.

Thanks,
Yoshihiro Shimoda

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel