Re: More USB_QUIRK_RESET_RESUME devices

Alan Stern <[email protected]>
Newsgroups gmane.linux.usb.devel
Message-ID <[email protected]>
On Tue, 4 Sep 2007, Lamarque Vieira Souza wrote:

> > We would like to keep the quirk entries in numerical order by
> > Vendor ID and then Product ID.  Please resubmit your patch with the
> > new entries in their correct positions.
> 
> 	Here is new patch and thanks.

That's not what I meant.  You wrote:

> --- linux-2.6.23-rc5/drivers/usb/core/quirks.c	2007-09-04 14:28:08.000000000 -0300
> +++ linux-2.6.23-rc5-lvs/drivers/usb/core/quirks.c	2007-09-04 14:30:37.000000000 -0300
> @@ -75,6 +75,12 @@ static const struct usb_device_id usb_qu
>  
>  	/* Philips PSC805 audio device */
>  	{ USB_DEVICE(0x0471, 0x0155), .driver_info = USB_QUIRK_RESET_RESUME },
> +	/* M-Systems Flash Disk Pioneers */
> +	{ USB_DEVICE(0x08ec, 0x1000), .driver_info = USB_QUIRK_RESET_RESUME },
> +	/* SKYMEDI USB_DRIVE */
> +	{ USB_DEVICE(0x1516, 0x8628), .driver_info = USB_QUIRK_RESET_RESUME },
> +	/* INTEL VALUE SSD */
> +	{ USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
>  
>  	/* Alcor multi-card reader */
>  	{ USB_DEVICE(0x058f, 0x6366), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },

So now you've got a device with Vendor ID 0x8086 coming _before_ a 
device with Vendor ID 0x058f.  That's not in numeric order.

Alan Stern


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.