Re: More USB_QUIRK_RESET_RESUME devices

Em Terça 04 Setembro 2007 15:32, Alan Stern escreveu:
 > On Tue, 4 Sep 2007, Lamarque Vieira Souza wrote:
> > > We would like to keep the quirk entries in numerical order by
> > > Vendor ID and then Product ID.  Please resubmit your patch with
> > > the new entries in their correct positions.
> >
> > 	Here is new patch and thanks.
>
> That's not what I meant.  You wrote:
> > --- linux-2.6.23-rc5/drivers/usb/core/quirks.c	2007-09-04
> > 14:28:08.000000000 -0300 +++
> > linux-2.6.23-rc5-lvs/drivers/usb/core/quirks.c	2007-09-04
> > 14:30:37.000000000 -0300 @@ -75,6 +75,12 @@ static const struct
> > usb_device_id usb_qu
> >
> >  	/* Philips PSC805 audio device */
> >  	{ USB_DEVICE(0x0471, 0x0155), .driver_info =
> > USB_QUIRK_RESET_RESUME }, +	/* M-Systems Flash Disk Pioneers */
> > +	{ USB_DEVICE(0x08ec, 0x1000), .driver_info =
> > USB_QUIRK_RESET_RESUME }, +	/* SKYMEDI USB_DRIVE */
> > +	{ USB_DEVICE(0x1516, 0x8628), .driver_info =
> > USB_QUIRK_RESET_RESUME }, +	/* INTEL VALUE SSD */
> > +	{ USB_DEVICE(0x8086, 0xf1a5), .driver_info =
> > USB_QUIRK_RESET_RESUME },
> >
> >  	/* Alcor multi-card reader */
> >  	{ USB_DEVICE(0x058f, 0x6366), .driver_info =
> > USB_QUIRK_NO_AUTOSUSPEND },
>
> So now you've got a device with Vendor ID 0x8086 coming _before_ a
> device with Vendor ID 0x058f.  That's not in numeric order.

	Well, I got it that way but I saw several other devices out of order 
in 2.6.23-rc5, so tried to keep all the USB_QUIRK_RESET_RESUME 
together. Well, this new patch adds the devices in the correct places 
(I hope). I left the out-of-order devices as they were.

-- 
 Lamarque Vieira Souza
 Senior Architect and Developer - Metasys
 http://www.metasys.com.br
 Tel.: +55 31 3296-9040 - Ramal 244
 International Syst S/A

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

--- linux-2.6.23-rc5/drivers/usb/core/quirks.c	2007-09-04 14:28:08.000000000 -0300
+++ linux-2.6.23-rc5-lvs/drivers/usb/core/quirks.c	2007-09-04 15:56:11.000000000 -0300
@@ -68,8 +68,12 @@ static const struct usb_device_id usb_qu
 	{ USB_DEVICE(0x05d8, 0x4005), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
 	/* Agfa Snapscan1212u */
 	{ USB_DEVICE(0x06bd, 0x2061), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
+	/* M-Systems Flash Disk Pioneers */
+	{ USB_DEVICE(0x08ec, 0x1000), .driver_info = USB_QUIRK_RESET_RESUME },
 	/* Seagate RSS LLC */
 	{ USB_DEVICE(0x0bc2, 0x3000), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
+	/* SKYMEDI USB_DRIVE */
+	{ USB_DEVICE(0x1516, 0x8628), .driver_info = USB_QUIRK_RESET_RESUME },
 	/* Umax [hex] Astra 3400U */
 	{ USB_DEVICE(0x1606, 0x0060), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
 
@@ -87,6 +91,9 @@ static const struct usb_device_id usb_qu
 	{ USB_DEVICE(0x0fca, 0x0004), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
 	{ USB_DEVICE(0x0fca, 0x0006), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
 
+	/* INTEL VALUE SSD */
+	{ USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
+
 	{ }  /* terminating entry must be last */
 };