Re: Review of patch for MS USB keyboard

On Fri, 21 Sep 2007, Khelben Blackstaff wrote:

> I tried to use evtest and getkeycodes to read the missing scancodes as 
> most howtos mention for usb keyboards. They didn't work and after 
> googling i learned about the keyboards using hid codes. To make a long 
> story short, i found an old patch for Natural keyboard and a 
> newer/better version included in mr. Morton's 2.6.23-rc6-mm1 patchset.

Yes, that would probably be my patch which got into -mm through my git 
tree, no need to CC akpm on this, please remove him for any further 
conversation, thanks.

> 1 hunk) I included my keyboard (subid f9) in the matching

Probably renaming the macro would also be good, when it is now used to 
match not only the 4K keyboard.

> 2 hunk) Added HID code 0x182 which is the Favorites key.  At first i 
>   named it KEY_FAVORITES but found out that keycodes > 255 don't work in 
>   the X server so renamed it to KEY_BOOKMARKS

Hmm, so they keep on breaking the HID specification, oh well :/ 0x182 
should be "Programmable button configuration".

> 3 hunk) Added HID code 0x19c which is the lock key. I didn't find any
> name for this so i named it KEY_COMPUTER. 

0x19c should be, according to the specification "AL Logoff". Is this also 
the case? I am not sure though which of the already existing KEY_ 
constants should suit this. Do you have any idea, Dmitry?

> Also i changed KEY_SPELLCHECK to KEY_FIND because KEY_SPELLCHECK > 255 I 
> know KEY_FIND itsn't right but just till X supports larger keycodes.

This is not acceptable, sorry.

X should accept > 255 codes through evdev, right?

> Added HID codes 0x1b6,0x1b7 which are the Camera(Media) and Sound 
> buttons

OK, 0x1b6 and 0x1b7 are currently reserved by the specification, so we can 
add them, but it will very probably break when new usage tables are out :(

> 4 hunk) Changed Zoom In/Out to Scroll Up/Down again due to the 255 
>   issue. (Also Scroll is more useful than zoom i guess.

Again, not acceptable, sorry.

> I am sorry if i made you tired with my long post and thank you for your 
> time.

Thanks for making the patch, it'll need some cleanups before I could 
accept it though, see above.

BTW, it would be nice if you could somehow teach your mail client to wrap 
lines properly.

Thanks!

-- 
Jiri Kosina

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel