Re: Review of patch for MS USB keyboard
"Dmitry Torokhov" <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Jiri, On 9/21/07, Jiri Kosina <[email protected]> wrote: > On Fri, 21 Sep 2007, Khelben Blackstaff wrote: > > > 3 hunk) Added HID code 0x19c which is the lock key. I didn't find any > > name for this so i named it KEY_COMPUTER. > > 0x19c should be, according to the specification "AL Logoff". Is this also > the case? I am not sure though which of the already existing KEY_ > constants should suit this. Do you have any idea, Dmitry? > I don't think we have logoff. But based on the description we coud probably map it to KEY_SCREENLOCK (AKA KEY_COFFEE). > > Also i changed KEY_SPELLCHECK to KEY_FIND because KEY_SPELLCHECK > 255 I > > know KEY_FIND itsn't right but just till X supports larger keycodes. > > This is not acceptable, sorry. > > X should accept > 255 codes through evdev, right? > Yep. 255 is the limitation of PS/2 protocol. > > Added HID codes 0x1b6,0x1b7 which are the Camera(Media) and Sound > > buttons > > OK, 0x1b6 and 0x1b7 are currently reserved by the specification, so we can > add them, but it will very probably break when new usage tables are out :( > I wonder if we should leave such nonstandard mappings to HAL - it can easily do that by VID/PID now that USB allows changing keympas on fly. -- Dmitry ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel