Re: Review of patch for MS USB keyboard
Jiri Kosina <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, please, try not to remove relevant CCs when responding to mails, it is then harder to find your reply. Thanks. On Sat, 22 Sep 2007, Khelben Blackstaff wrote: > > OK, 0x1b6 and 0x1b7 are currently reserved by the specification, so we can > > add them, but it will very probably break when new usage tables are out :( > Checked that too. The codes are 0x1b6 and 0x1b7 as i said, but these > seem correct. Page 83 of the 1.12 specification mentions 0x1b6 as "image > browser" and 0x1b7 as "audio browser". The icons on these two keys show > the same thing. A camera and a headset. Sorry, you are right, I was probably temporarily blind when looking at the specs. > > I don't think we have logoff. But based on the description we coud > > probably map it to KEY_SCREENLOCK (AKA KEY_COFFEE). > I searched for some "lock" key but didn't find anything, that is why i > gave it an irrelevant name. I saw KEY_COFFEE and wondered what use did > it have. It didn't occur to me that when i lock the screen i will go for > coffee :) I changed it to KEY_COFFEE as you suggested, but i have read > in the specification that code 0x19c is Logoff. So, i guess a KEY_LOGOFF > should be added to input.h and 0x19c should be specified as KEY_LOGOFF. > I didn't do that in the patches because i didn't know which is the > correct way to do it. I'd leave this to Dmitry to judge. > Noticed something though. xev reports button events and not key events > as if mouse buttons were pressed. Also, in console buttons 1,2,3 react > as the left/middle/right mouse buttons. Is this the wanted behavior ? You are right, the mapping is not exactly correct, I will fix that up in my tree. So, once Dmitry tells what he thinks about KEY_LOGOFF, please resend your patch with some short changelog entry and Signed-off-by line, and I will happily merge it. Thanks, -- Jiri Kosina ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel