Re: [PATCH] USB: uevent environment key fix

I don't follow the change below, at least in terms of the
patch comment ... it doesn't mention *removing* functionality,
and that's what this chunk seems to do (at first glance).

Removing this stuff wouldn't necessarily be bad -- it was for
the now-ancient hotplug scripts, which I don't think get used
much with current kernels.  (Though at least one 2.6.10 based
embeddable distro used them...)  But if it's being removed,
that behavioral change should be explicit in patch comments.

- Dave


On Tuesday 06 November 2007, Alan Stern wrote:
> --- usb-2.6.orig/drivers/usb/core/message.c
> +++ usb-2.6/drivers/usb/core/message.c
> @@ -1346,34 +1346,10 @@ static int usb_if_uevent(struct device *
>  
>         ...
>  
> -#ifdef CONFIG_USB_DEVICEFS
> -       if (add_uevent_var(env, "DEVICE=/proc/bus/usb/%03d/%03d",
> -                          usb_dev->bus->busnum, usb_dev->devnum))
> -               return -ENOMEM;
> -#endif
> -
> -       if (add_uevent_var(env, "PRODUCT=%x/%x/%x",
> -                          le16_to_cpu(usb_dev->descriptor.idVendor),
> -                          le16_to_cpu(usb_dev->descriptor.idProduct),
> -                          le16_to_cpu(usb_dev->descriptor.bcdDevice)))
> -               return -ENOMEM;
> -
> -       if (add_uevent_var(env, "TYPE=%d/%d/%d",
> -                          usb_dev->descriptor.bDeviceClass,
> -                          usb_dev->descriptor.bDeviceSubClass,
> -                          usb_dev->descriptor.bDeviceProtocol))
> -               return -ENOMEM;
> -



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel