Re: [PATCH] USB: uevent environment key fix
Alan Stern <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 6 Nov 2007, David Brownell wrote: > I don't follow the change below, at least in terms of the > patch comment ... it doesn't mention *removing* functionality, > and that's what this chunk seems to do (at first glance). The chunk removes _duplicated_ functionality. The same code is still present in a different subroutine. The duplication was at the request of a user who wasn't getting the environment fields he needed in the interface uevent messages. Now that the uevent core has been fixed up we see that those fields are being added twice -- hence this patch. > Removing this stuff wouldn't necessarily be bad -- it was for > the now-ancient hotplug scripts, which I don't think get used > much with current kernels. (Though at least one 2.6.10 based > embeddable distro used them...) But if it's being removed, > that behavioral change should be explicit in patch comments. Alan Stern ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel