Re: usb_submit_urb from callback

On Mon, Nov 12, 2007 at 04:07:55PM -0500, Chris Hiszpanski wrote:
> > > Hi Greg,
> > >
> > > I found these prototype differences between the 2.4 and 2.6 kernels:
> > >
> > > /* 2.4 kernel */
> > > int usb_submit_urb(struct urb *urb);
> > >
> > > /* 2.6 kernel */
> > > int usb_submit_urb(struct urb *urb, int mem_flags);
> > >
> > > In the 2.6 kernel, to re-submit a URB from within a URB's callback
> function,
> > > the second argument must be GFP_ATOMIC. How is URB re-submission
> > > from within a URB's callback function handled under the 2.4 kernel,
> without
> > > the mem_flags argument?
> >
> > Might I ask why you are caring about the 2.4 usb stack?  That kernel is
> > not supported anymore...
> 
> We still use 2.4 on our production systems.

My sympathies :)

But are you writing a new USB driver for these machine?  If so, for what
hardware?

As to your original question, we just guess as to the flags that are
needed, always using GFP_KERNEL and so, things can break at times.  That
is why we changed things in the 2.5 development cycle.

hope this helps,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel