Re: [PATCH] SCSI error handling on some USB disks needs allow_restartcp

On Tue, Nov 13, 2007 at 03:41:21PM +0100, Jean Delvare wrote:
> > +	vendor = us->pusb_dev->manufacturer;
> > +	product = us->pusb_dev->product;
> > +
> > +	if (vendor && product &&
> > +	    !strcmp(vendor, "Seagate") &&
> > +	    (!strcmp(product, "FreeAgent Pro") ||
> > +	     !strcmp(product, "FreeAgentDesktop")))
> > +		sdev->allow_restart = 1;
> > +
> >   	/*
> >   	 * The UFI spec treates the Peripheral Qualifier bits in an
> >   	 * INQUIRY result as reserved and requires devices to set them

This is overkill.  It's almost certainly safe to just set allow_restart = 1
always, since the SCSI layer won't send a START_STOP unless it gets an
error, anyway.

Long ago, every device got a START_STOP, and a lot of them broke.  But now,
the devices that can't tollerate a START_STOP shouldn't trigger those code
paths.

Matt

-- 
Matthew Dharm                              Home: [email protected] 
Maintainer, Linux USB Mass Storage Driver

Somebody call an exorcist!
					-- Dust Puppy
User Friendly, 5/16/1998

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQFHOdInHL9iwnUZqnkRAu2TAJ9ha0RvrNsyImNYUhFlJaX12E7zcgCeNiUa
K81hfeI3ZUX/hymkwWKVb20=
=RzjA
-----END PGP SIGNATURE-----