Re: [PATCH v2] Re: another unusual flag for a really limited device

Matthew Dharm <[email protected]>
Newsgroups gmane.linux.usb.devel
Organization One Eyed Alien Networks
Message-ID <[email protected]>
On Wed, Nov 28, 2007 at 12:50:20PM -0600, Doug Maxey wrote:
> 
> On Wed, 28 Nov 2007 10:27:02 PST, Pete Zaitcev wrote:
> > On Wed, 28 Nov 2007 11:14:02 -0600, Doug Maxey <[email protected]> wrote:
> > 
> > > +++ b/include/linux/usb_usual.h
> > > @@ -48,7 +48,10 @@
> > >  	US_FLAG(IGNORE_DEVICE,	0x00000800)			\
> > >  		/* Don't claim device */			\
> > >  	US_FLAG(CAPACITY_HEURISTICS,	0x00001000)		\
> > > -		/* sometimes sizes is too big */
> > > +		/* sometimes sizes is too big */		\
> > > +	US_FLAG(MAX_SECTORS_MIN,0x00001000)			\
> > > +		/* Sets max_sectors to arch min */
> > 
> > Are you sure you didn't want 0x2000 here?
> 
> Doesn't matter to me.  Was shifting to the left in sequence, I thought.

Shifting left *is* what you want.  But you used the same value as
CAPACITY_HEURISTICS -- they must all be unique.

Matt

-- 
Matthew Dharm                              Home: [email protected] 
Maintainer, Linux USB Mass Storage Driver

C:  Like the Furby?
DP: He gives me the creeps.  Think the SPCA will take him?
					-- Cobb and Dust Puppy
User Friendly, 1/2/1999

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
signature.asc (application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQFHTbkHHL9iwnUZqnkRAjI1AJ4mQtX+rVkK3JT/S/zI18K10BDXAACgoNVc
F/9zR3M7W1eAQBBTtAli+0k=
=nuUP
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.