Re: [PATCH v2] Re: another unusual flag for a really limited device
Doug Maxey <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 28 Nov 2007 10:52:55 PST, Matthew Dharm wrote: > On Wed, Nov 28, 2007 at 12:50:20PM -0600, Doug Maxey wrote: > > > > On Wed, 28 Nov 2007 10:27:02 PST, Pete Zaitcev wrote: > > > On Wed, 28 Nov 2007 11:14:02 -0600, Doug Maxey <[email protected]> wrote: > > > > > > > +++ b/include/linux/usb_usual.h > > > > @@ -48,7 +48,10 @@ > > > > US_FLAG(IGNORE_DEVICE, 0x00000800) \ > > > > /* Don't claim device */ \ > > > > US_FLAG(CAPACITY_HEURISTICS, 0x00001000) \ > > > > - /* sometimes sizes is too big */ > > > > + /* sometimes sizes is too big */ \ > > > > + US_FLAG(MAX_SECTORS_MIN,0x00001000) \ > > > > + /* Sets max_sectors to arch min */ > > > > > > Are you sure you didn't want 0x2000 here? > > > > Doesn't matter to me. Was shifting to the left in sequence, I thought. > > Shifting left *is* what you want. But you used the same value as > CAPACITY_HEURISTICS -- they must all be unique. buh? what? we can't have duplicate (or overloaded> flags? :-> ++doug ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel