Re: xvidmode extension
Iban Hatchondo <[email protected]> Wed, 30 Apr 2003 11:54:40 +0200
| Newsgroups | gmane.lisp.clx.devel |
|---|---|
| Message-ID | <[email protected]> |
Christophe Rhodes wrote: > Christophe Rhodes <[email protected]> writes: > > >>So probably what CLX meant was, when result-type is NIL, a NULL >>result-type in the READ-SEQUENCE-CARD32 accessors? I haven't looked >>at it very carefully yet, but it's quite possible that other bits of >>CLX don't work for sbcl, either (anything that uses SEQUENCE-PUT >>without specifying a RESULT-TYPE? Dunno). > > > The attached patch makes it work for me. I think that whatever our conclusions could be your patch is correct. I forgot to indicate the result-type, and I should have done that. I forgot to indicate the result-type in every other use of sequence-get, so I probably should correct this and repost the extension. Then you guies could commiting it in the cvs of clocc, cmucl, sbcl ... ? > If anyone has any clx > internals documentation, it would be interesting to know what the > documentation for SEQUENCE-GET was: if the RESULT-TYPE argument is > unprovided, is it meant to default to LIST? If so, then probably it > ought to be explicit in DEFINE-ACCESSOR SEQUENCE, rather than implicit > in the lisp implementation's treatment of (MAKE-SEQUENCE NIL <x>). > I guess you're right. Maybe Peter could gives us a clue ? Iban.