syntax error in recent Slime commit
Douglas Katzman <[email protected]> Wed, 16 Dec 2020 12:31:34 -0500
| Newsgroups | gmane.lisp.slime.devel,gmane.lisp.steel-bank.devel |
|---|---|
| Message-ID | <CAOrNaswCj+SB+qonB=xVXgOUU4a5UXOsYCKPmRK9F2r+8ROtBQ@mail.gmail.com> |
--000000000000d525bd05b6983ff0 Content-Type: text/plain; charset="UTF-8" This change causes a malformed let in an older SBCL that has both a compatibility accessor (%code-entry-points) and the preferred accessor (%code-entry-point). It works in new SBCL which only has the new, and very old SBCL which only has the old, but not in the interim releases which had both. commit 53badd278bf5ac36922d7b417f44e1c21e724547 Author: Stas Boukarev <[email protected]> Date: Tue Dec 15 01:38:46 2020 +0300 No more sb-kernel:%code-entry-points. *diff --git a/contrib/swank-sprof.lisp b/contrib/swank-sprof.lisp* *index 675240ff..9c640ec3 100644* *--- a/contrib/swank-sprof.lisp* *+++ b/contrib/swank-sprof.lisp* @@ -138,7 +138,10 @@ (debug-info (sb-sprof::node-debug-info node))) (or (when (typep debug-info 'sb-di::compiled-debug-fun) (let* ((component (sb-di::compiled-debug-fun-component debug-info)) - (function (sb-kernel::%code-entry-points component))) + (function #+#.(swank/backend:with-symbol '%code-entry-points 'sb-kernel) + (sb-kernel::%code-entry-points component) + #+#.(swank/backend:with-symbol '%code-entry-point 'sb-kernel) + (sb-kernel:%code-entry-point component 0))) (when function (find-source-location function)))) `(:error "No source location available")))) d --000000000000d525bd05b6983ff0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">This change causes a malformed let in an older SBCL that h= as both a compatibility accessor (%code-entry-points) and the preferred acc= essor (%code-entry-point).<div>It works in new SBCL which only has the new,= and very old SBCL which only has the old, but not in the interim releases = which had both.<br><div><div><br></div><div> <p class=3D"gmail-p1" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(159,160,28)"><span class=3D"gmail-s1" styl= e=3D"font-variant-ligatures:no-common-ligatures">commit 53badd278bf5ac36922= d7b417f44e1c21e724547</span></p> <p class=3D"gmail-p2" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0)"><span class=3D"gmail-s1" style=3D"= font-variant-ligatures:no-common-ligatures">Author: Stas Boukarev <<a hr= ef=3D"mailto:[email protected]">[email protected]</a>></span></p> <p class=3D"gmail-p2" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0)"><span class=3D"gmail-s1" style=3D"= font-variant-ligatures:no-common-ligatures">Date: <span class=3D"gmail-Appl= e-converted-space">=C2=A0 </span>Tue Dec 15 01:38:46 2020 +0300</span></p> <p class=3D"gmail-p3" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span class=3D"gma= il-s1" style=3D"font-variant-ligatures:no-common-ligatures"></span><br></p> <p class=3D"gmail-p2" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0)"><span class=3D"gmail-s1" style=3D"= font-variant-ligatures:no-common-ligatures"><span class=3D"gmail-Apple-conv= erted-space">=C2=A0 =C2=A0 </span>No more sb-kernel:%code-entry-points.</sp= an></p> <p class=3D"gmail-p3" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span class=3D"gma= il-s1" style=3D"font-variant-ligatures:no-common-ligatures"></span><br></p> <p class=3D"gmail-p2" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0)"><span class=3D"gmail-s1" style=3D"= font-variant-ligatures:no-common-ligatures"><b>diff --git a/contrib/swank-s= prof.lisp b/contrib/swank-sprof.lisp</b></span></p> <p class=3D"gmail-p2" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0)"><span class=3D"gmail-s1" style=3D"= font-variant-ligatures:no-common-ligatures"><b>index 675240ff..9c640ec3 100= 644</b></span></p> <p class=3D"gmail-p2" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0)"><span class=3D"gmail-s1" style=3D"= font-variant-ligatures:no-common-ligatures"><b>--- a/contrib/swank-sprof.li= sp</b></span></p> <p class=3D"gmail-p2" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0)"><span class=3D"gmail-s1" style=3D"= font-variant-ligatures:no-common-ligatures"><b>+++ b/contrib/swank-sprof.li= sp</b></span></p> <p class=3D"gmail-p4" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(46,174,187)"><span class=3D"gmail-s1" styl= e=3D"font-variant-ligatures:no-common-ligatures">@@ -138,7 +138,10 @@</span= ></p> <p class=3D"gmail-p2" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0)"><span class=3D"gmail-s1" style=3D"= font-variant-ligatures:no-common-ligatures"><span class=3D"gmail-Apple-conv= erted-space">=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>(debug-info (sb-spro= f::node-debug-info node)))</span></p> <p class=3D"gmail-p2" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0)"><span class=3D"gmail-s1" style=3D"= font-variant-ligatures:no-common-ligatures"><span class=3D"gmail-Apple-conv= erted-space">=C2=A0=C2=A0 =C2=A0 </span>(or (when (typep debug-info 'sb= -di::compiled-debug-fun)</span></p> <p class=3D"gmail-p2" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0)"><span class=3D"gmail-s1" style=3D"= font-variant-ligatures:no-common-ligatures"><span class=3D"gmail-Apple-conv= erted-space">=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>(let* ((compon= ent (sb-di::compiled-debug-fun-component debug-info))</span></p> <p class=3D"gmail-p5" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(180,36,25)"><span class=3D"gmail-s1" style= =3D"font-variant-ligatures:no-common-ligatures">- <span class=3D"gmail-Appl= e-converted-space">=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = </span>(function (sb-kernel::%code-entry-points component)))</span></p> <p class=3D"gmail-p6" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(47,180,29)"><span class=3D"gmail-s1" style= =3D"font-variant-ligatures:no-common-ligatures">+ <span class=3D"gmail-Appl= e-converted-space">=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = </span>(function #+#.(swank/backend:with-symbol '%code-entry-points = 9;sb-kernel)</span></p> <p class=3D"gmail-p6" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(47,180,29)"><span class=3D"gmail-s1" style= =3D"font-variant-ligatures:no-common-ligatures">+ <span class=3D"gmail-Appl= e-converted-space">=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>(sb-kernel::%code-entry-points co= mponent)</span></p> <p class=3D"gmail-p6" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(47,180,29)"><span class=3D"gmail-s1" style= =3D"font-variant-ligatures:no-common-ligatures">+ <span class=3D"gmail-Appl= e-converted-space">=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>#+#.(swank/backend:with-symbol &#= 39;%code-entry-point 'sb-kernel)</span></p> <p class=3D"gmail-p6" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(47,180,29)"><span class=3D"gmail-s1" style= =3D"font-variant-ligatures:no-common-ligatures">+ <span class=3D"gmail-Appl= e-converted-space">=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>(sb-kernel:%code-entry-point comp= onent 0)))</span></p> <p class=3D"gmail-p2" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0)"><span class=3D"gmail-s1" style=3D"= font-variant-ligatures:no-common-ligatures"><span class=3D"gmail-Apple-conv= erted-space">=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>(when f= unction</span></p> <p class=3D"gmail-p2" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0)"><span class=3D"gmail-s1" style=3D"= font-variant-ligatures:no-common-ligatures"><span class=3D"gmail-Apple-conv= erted-space">=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>= (find-source-location function))))</span></p> <p class=3D"gmail-p2" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0)"><span class=3D"gmail-s1" style=3D"= font-variant-ligatures:no-common-ligatures"><span class=3D"gmail-Apple-conv= erted-space">=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>`(:error "No sou= rce location available"))))</span></p> <p class=3D"gmail-p2" style=3D"margin:0px;font-variant-numeric:normal;font-= variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:no= rmal;font-family:Menlo;color:rgb(0,0,0)"><span class=3D"gmail-s1" style=3D"= font-variant-ligatures:no-common-ligatures">d</span></p></div></div></div><= /div> --000000000000d525bd05b6983ff0--