Re: syntax error in recent Slime commit

--===============9010266867063760796==
Content-Type: multipart/alternative; boundary="000000000000a5444a05b6985e9b"

--000000000000a5444a05b6985e9b
Content-Type: text/plain; charset="UTF-8"

Fixed, thanks.

On Wed, Dec 16, 2020 at 8:31 PM Douglas Katzman <[email protected]> wrote:

> This change causes a malformed let in an older SBCL that has both a
> compatibility accessor (%code-entry-points) and the preferred accessor
> (%code-entry-point).
> It works in new SBCL which only has the new, and very old SBCL which only
> has the old, but not in the interim releases which had both.
>
> commit 53badd278bf5ac36922d7b417f44e1c21e724547
>
> Author: Stas Boukarev <[email protected]>
>
> Date:   Tue Dec 15 01:38:46 2020 +0300
>
>
>     No more sb-kernel:%code-entry-points.
>
>
> *diff --git a/contrib/swank-sprof.lisp b/contrib/swank-sprof.lisp*
>
> *index 675240ff..9c640ec3 100644*
>
> *--- a/contrib/swank-sprof.lisp*
>
> *+++ b/contrib/swank-sprof.lisp*
>
> @@ -138,7 +138,10 @@
>
>           (debug-info (sb-sprof::node-debug-info node)))
>
>      (or (when (typep debug-info 'sb-di::compiled-debug-fun)
>
>            (let* ((component (sb-di::compiled-debug-fun-component
> debug-info))
>
> -                 (function (sb-kernel::%code-entry-points component)))
>
> +                 (function #+#.(swank/backend:with-symbol
> '%code-entry-points 'sb-kernel)
>
> +                           (sb-kernel::%code-entry-points component)
>
> +                           #+#.(swank/backend:with-symbol
> '%code-entry-point 'sb-kernel)
>
> +                           (sb-kernel:%code-entry-point component 0)))
>
>              (when function
>
>                (find-source-location function))))
>
>          `(:error "No source location available"))))
>
> d
>

--000000000000a5444a05b6985e9b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Fixed, thanks.</div><br><div class=3D"gmail_quote"><div di=
r=3D"ltr" class=3D"gmail_attr">On Wed, Dec 16, 2020 at 8:31 PM Douglas Katz=
man &lt;<a href=3D"mailto:[email protected]">[email protected]</a>&gt; wrote:=
<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8=
ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr=
">This change causes a malformed let in an older SBCL that has both a compa=
tibility accessor (%code-entry-points) and the preferred accessor (%code-en=
try-point).<div>It works in new SBCL which only has the new, and very old S=
BCL which only has the old, but not in the interim releases which had both.=
<br><div><div><br></div><div>





<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(159,160,28)"><span style=3D"font-variant-ligatures:no-common-=
ligatures">commit 53badd278bf5ac36922d7b417f44e1c21e724547</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0)"><span style=3D"font-variant-ligatures:no-common-ligat=
ures">Author: Stas Boukarev &lt;<a href=3D"mailto:[email protected]" targe=
t=3D"_blank">[email protected]</a>&gt;</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0)"><span style=3D"font-variant-ligatures:no-common-ligat=
ures">Date: <span>=C2=A0 </span>Tue Dec 15 01:38:46 2020 +0300</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0);min-height:13px"><span style=3D"font-variant-ligatures=
:no-common-ligatures"></span><br></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0)"><span style=3D"font-variant-ligatures:no-common-ligat=
ures"><span>=C2=A0 =C2=A0 </span>No more sb-kernel:%code-entry-points.</spa=
n></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0);min-height:13px"><span style=3D"font-variant-ligatures=
:no-common-ligatures"></span><br></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0)"><span style=3D"font-variant-ligatures:no-common-ligat=
ures"><b>diff --git a/contrib/swank-sprof.lisp b/contrib/swank-sprof.lisp</=
b></span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0)"><span style=3D"font-variant-ligatures:no-common-ligat=
ures"><b>index 675240ff..9c640ec3 100644</b></span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0)"><span style=3D"font-variant-ligatures:no-common-ligat=
ures"><b>--- a/contrib/swank-sprof.lisp</b></span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0)"><span style=3D"font-variant-ligatures:no-common-ligat=
ures"><b>+++ b/contrib/swank-sprof.lisp</b></span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(46,174,187)"><span style=3D"font-variant-ligatures:no-common-=
ligatures">@@ -138,7 +138,10 @@</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0)"><span style=3D"font-variant-ligatures:no-common-ligat=
ures"><span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>(debug-info (sb-sprof=
::node-debug-info node)))</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0)"><span style=3D"font-variant-ligatures:no-common-ligat=
ures"><span>=C2=A0=C2=A0 =C2=A0 </span>(or (when (typep debug-info &#39;sb-=
di::compiled-debug-fun)</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0)"><span style=3D"font-variant-ligatures:no-common-ligat=
ures"><span>=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>(let* ((compone=
nt (sb-di::compiled-debug-fun-component debug-info))</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(180,36,25)"><span style=3D"font-variant-ligatures:no-common-l=
igatures">- <span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <=
/span>(function (sb-kernel::%code-entry-points component)))</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(47,180,29)"><span style=3D"font-variant-ligatures:no-common-l=
igatures">+ <span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <=
/span>(function #+#.(swank/backend:with-symbol &#39;%code-entry-points &#39=
;sb-kernel)</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(47,180,29)"><span style=3D"font-variant-ligatures:no-common-l=
igatures">+ <span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>(sb-kernel::%code-entry-points co=
mponent)</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(47,180,29)"><span style=3D"font-variant-ligatures:no-common-l=
igatures">+ <span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>#+#.(swank/backend:with-symbol &#=
39;%code-entry-point &#39;sb-kernel)</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(47,180,29)"><span style=3D"font-variant-ligatures:no-common-l=
igatures">+ <span>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>(sb-kernel:%code-entry-point comp=
onent 0)))</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0)"><span style=3D"font-variant-ligatures:no-common-ligat=
ures"><span>=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>(when fu=
nction</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0)"><span style=3D"font-variant-ligatures:no-common-ligat=
ures"><span>=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>(=
find-source-location function))))</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0)"><span style=3D"font-variant-ligatures:no-common-ligat=
ures"><span>=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 </span>`(:error &quot;No sour=
ce location available&quot;))))</span></p>
<p style=3D"margin:0px;font-variant-numeric:normal;font-variant-east-asian:=
normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Me=
nlo;color:rgb(0,0,0)"><span style=3D"font-variant-ligatures:no-common-ligat=
ures">d</span></p></div></div></div></div>
</blockquote></div>

--000000000000a5444a05b6985e9b--


--===============9010266867063760796==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--===============9010266867063760796==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Sbcl-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sbcl-devel

--===============9010266867063760796==--