Re: master: Fix and re-enable a test

I was planning on making make-array produce an error on unknown types.
That's why I just temporarily commented it out.

On Thu, Mar 19, 2026 at 1:22 AM crhodes via Sbcl-commits
<[email protected]> wrote:
>
> The branch "master" has been updated in SBCL:
>        via  52a523e627b62dbb5cfe3a04a0856434ea649627 (commit)
>       from  0e79f0504790aa4ed902762c19f1f16235181792 (commit)
>
> - Log -----------------------------------------------------------------
> commit 52a523e627b62dbb5cfe3a04a0856434ea649627
> Author: Christophe Rhodes <[email protected]>
> Date:   Wed Mar 18 22:21:19 2026 +0000
>
>     Fix and re-enable a test
>
>     If (make-array <> :element-type 'undefined) succeeds, check that
>     upgraded-array-element-type is consistent with what it returns.  If it
>     errors, check that upgraded-array-element-type errors too.
> ---
>  tests/type.impure.lisp | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/tests/type.impure.lisp b/tests/type.impure.lisp
> index 593246ea2..90f46bb67 100644
> --- a/tests/type.impure.lisp
> +++ b/tests/type.impure.lisp
> @@ -58,9 +58,17 @@
>
>  ;;; sbcl-0.6.10 did (UPGRADED-ARRAY-ELEMENT-TYPE 'SOME-UNDEF-TYPE)=>T
>  ;;; and (UPGRADED-COMPLEX-PART-TYPE 'SOME-UNDEF-TYPE)=>T.
> -;; (with-test (:name (upgraded-array-element-type :undefined))
> -;;   (assert-error (upgraded-array-element-type 'some-undef-type))
> -;;   (assert (eql (upgraded-array-element-type t) t)))
> +;;;
> +;;; some time later, we decided that (U-A-E-T 'SOME-UNDEF-TYPE) should
> +;;; in fact return T, and be consistent with calls like
> +;;; (MAKE-ARRAY <x> :ELEMENT-TYPE 'SOME-UNDEF-TYPE)
> +(with-test (:name (upgraded-array-element-type :undefined))
> +  (let (array)
> +    (handler-case
> +        (setf array (make-array 3 :element-type 'some-undef-type))
> +      (error () (assert-error (upgraded-array-element-type 'some-undef-type))))
> +    (assert (eql (array-element-type array) (upgraded-array-element-type 'some-undef-type))))
> +  (assert (eql (upgraded-array-element-type t) t)))
>
>  (with-test (:name (upgraded-complex-part-type :undefined))
>    (assert-error (upgraded-complex-part-type 'some-undef-type))
>
> -----------------------------------------------------------------------
>
>
> hooks/post-receive
> --
> SBCL
>
>
> _______________________________________________
> Sbcl-commits mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/sbcl-commits


_______________________________________________
Sbcl-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sbcl-commits