Re: Rename xmm-tn-p to float-register-tn-p
Stas Boukarev <[email protected]>
| Newsgroups | gmane.lisp.steel-bank.devel |
|---|---|
| Message-ID | <CAF63=1312X2yJOs6=pHFbxQAs_qtJMhW49kAH-u-H0dWq4y7vg@mail.gmail.com> |
I think float-tn-p is a better name. > Another question: do you prefer patches, pull requests on GH, or just to > notify you when I have something? 🙂 I see you have applied > the GH branch, not the patch I send yesterday. That was just a diff, not a proper patch. On Thu, Aug 20, 2026 at 8:34 PM arthur miller <[email protected]> wrote: > > I would like to refactor an older function for Intel simd support. > Is that OK please? The reason: > > The name xmm-tn-p is a misnomer. The code checks whether a register is in > storage base for float registers which can be xmm, ymm, zmm, float, double, > complex float and complex double registers. While it is true xmm-tn-p asks if a > TN is in float registers SB, it also suggests we are differentiating between > ymm-tn-p, zmm-tn-p etc, which is not really the case here. It caused me a bug > and some investigation while working on mask registers support. > > Another question: do you prefer patches, pull requests on GH, or just to > notify you when I have something? 🙂 I see you have applied > the GH branch, not the patch I send yesterday. _______________________________________________ Sbcl-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sbcl-devel