Re: GeoIP Patch

On 335, 11 30, 2004 at 07:59:03PM +0000, Ian P. Christian wrote:
> Full modified Exiscan patch: http://pookey.co.uk/files/exiscan.patch.gz
> 
> Only started learning C again last week , for forgive any stupid mistakes ;)
> 
> Example usage:
>   warn    message     = X-Country-Code: $geoip_code
>           geoip       = *
>   warn    message     = X-Country: $geoip_country
>           geoip       = *

Looks good, except for this part: 

> diff -uPr exim-4.42-gentoo/src/acl.c exim-4.42-pookey/src/acl.c
> --- exim-4.42-gentoo/src/acl.c	2004-11-29 12:33:16.000000000 +0000
> +++ exim-4.42-pookey/src/acl.c	2004-11-30 12:27:24.000000000 +0000
> @@ -200,6 +214,16 @@
>      
>    0,                                               /* endpass */
>    
> +#ifdef GEOIP
> +  (1<<ACL_WHERE_AUTH)|                             /* geoip */
> +    (1<<ACL_WHERE_CONNECT)|(1<<ACL_WHERE_HELO)|
> +    (1<<ACL_WHERE_MIME)|(1<<ACL_WHERE_RCPT)|
> +    (1<<ACL_WHERE_ETRN)|(1<<ACL_WHERE_EXPN)|
> +    (1<<ACL_WHERE_MAILAUTH)|
> +    (1<<ACL_WHERE_MAIL)|(1<<ACL_WHERE_STARTTLS)|
> +    (1<<ACL_WHERE_VRFY),
> +#endif

Why this condition is so strict ?

IMHO GeoIP info can be usefull not only after DATA. For example
you can perform stricter address checks for connections from
'susspected' countries.

-- 
Andrey Panin		| Linux and UNIX system administrator
[email protected]		| PGP key: wwwkeys.pgp.net

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBtWk6by9O0+A2ZecRAqrxAKDS7bjkK/wuEOsA0HmiGgg19+ohNwCgmN1U
JPvJzezu33RuZj5cCq76bI0=
=bR6Z
-----END PGP SIGNATURE-----