Re: [PATCH 1/2] Add separate "Append to file" button
Wolfgang Denk <[email protected]> Wed, 13 Jun 2012 08:05:50 +0200
| Newsgroups | gmane.mail.exmh.devel |
|---|---|
| Message-ID | <[email protected]> |
Dear Valdis, In message <[email protected]> you wrote: > > > maybe add temporary codebefore the O_TRUNC or whatever to > > warn or confirm ? > > I'd opine that maybe it shouldn't be temporary code. Accidentally trashing > a file sucks. Oops? When you run a function that writes data to a file this is supposed just to do what you tell it - write data to a file. There is no difference between behaviour with or without this patch - in both cases the data will be writen to that file. The existing code does not use any waning either - and I have to admit that I consider all these "Do you really want..." interactions a major PITA. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] All he had was nothing, but that was something, and now it had been taken away. - Terry Pratchett, _Sourcery_