Re: [PATCH 1/2] Add separate "Append to file" button

Dear Chris,

In message <[email protected]> you wrote:
>
>  If 'Save to file' has been appending to files for more than a decade,
> I really think that it shouldn't be changed on people. If people really
> want this change in the main source, I would suggest two modifications
> here:

Yes, changing long-standing behavious is always a critical thing to
do.  But I really wonder how many users are actually aware of this
behaviour and using it?  The current behaviour is pretty much
counter-intuitive, and I tend to consider it a bug that should be
fixed.  [Actually my initial versions of this patch _only_ fixed this;
I added the "Append" only later and only for backward copatibility,
as I never used this myself.]

> - put the 'Append to file' button in the physical position where 'Save
>   to file' has been.
> - rename 'Save to file' to 'Write to file', so that people do not mistake
>   it for the old behavior.

That would be a trivial change.

Should I submit an updated patch with such a version?

> I would actually prefer a variant of this, where 'Save to file' retains
> the current behavior that people are expecting and 'Write to file' is
> introduced to overwrite files. This avoids a dangerous, incompatible
> change to long standing behavior.

Well, I dislike this.  "Save" and "Write" are pretty much synonyms to
me in this context, so this is likely to add confusion.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
"He was so narrow minded he could see through  a  keyhole  with  both
eyes ..."