Re: mh.tcl bug report and hopefully identification.
Brent Welch <[email protected]>
| Newsgroups | gmane.mail.exmh.devel |
|---|---|
| Message-ID | <[email protected]> |
Ahh - and I was cleverly looking at the post-patch code
and didn't see any conflicting uses of the seq variable.
This fix looks good.
>>>Hal DeVore said:
>
>
> >>>>> On Thu, 3 Apr 2003, "Brent" == Brent Welch wrote:
>
> Brent> Hmm - this proposed fix doesn't make sense to me.
> Brent> However, your stack trace implies that "seq" has
Brent> the value 5278-5285, that that variable is an input
> Brent> parameter and should be the name of a sequence. I can't
> Brent> see where "seq" is changed by anything (at least in my
> Brent> code)
>
> Here's the fix I actually applied to CVS. It is from an email
> that Klaus sent to me off-list.
>
> --Hal
>
>
> *** exmh/lib/mh.tcl Mi Apr 2 10:56:51 2003
> --- exmh/lib/mh.tcl.dist Di Apr 1 22:39:13 2003
> ***************
> *** 624,634 ****
> if {$mhPriv(mode,$thisseq) == "public"} {
> if {![regexp {^ *$} $seqs($thisseq)]} {
> if [regexp -- {-} $seqs($thisseq)] {
> ! set seq $seqs($thisseq)
> } else {
> ! set seq [MhSeqMake $seqs($thisseq)]
> }
> ! puts $out "$thisseq: $seq"
> }
> }
> }
> --- 624,634 ----
> if {$mhPriv(mode,$thisseq) == "public"} {
> if {![regexp {^ *$} $seqs($thisseq)]} {
> if [regexp -- {-} $seqs($thisseq)] {
> ! set realseq $seqs($thisseq)
> } else {
> ! set realseq [MhSeqMake $seqs($thisseq)]
> }
> ! puts $out "$thisseq: $realseq"
> }
> }
> }
> ***************
> *** 653,663 ****
> if {[string compare $mhPriv(mode,$thisseq) "private"] ==
0}
{
> if {![regexp {^ *$} $seqs($thisseq)]} {
> if [regexp -- {-} $seqs($thisseq)] {
> ! set seq $seqs($thisseq)
> } else {
> ! set seq [MhSeqMake $seqs($thisseq)]
> }
> ! puts $out "atr-$thisseq-$mhProfile(path)/$folder:
$s
eq"
> }
> }
> }
> --- 653,663 ----
> if {[string compare $mhPriv(mode,$thisseq) "private"] ==
0}
{
> if {![regexp {^ *$} $seqs($thisseq)]} {
> if [regexp -- {-} $seqs($thisseq)] {
> ! set realseq $seqs($thisseq)
> } else {
> ! set realseq [MhSeqMake $seqs($thisseq)]
> }
> ! puts $out "atr-$thisseq-$mhProfile(path)/$folder:
$r
ealseq"
> }
> }
> }
>
--
Brent Welch
Software Architect, Panasas Inc
Delivering the World's Most Scalable and Agile Storage Network
www.panasas.com
[email protected]