Re: pre-announce exmh-2.7.2

On Fri, 07 Jan 2005 21:04:50 GMT, Piete Brooks said:

(Splitting this into a new subthread)

> Some more problems:
> 
> cursor / Page up/down keys don't scroll in help (etc) windows [ not sure if 
> this used to work ]

It's easy enough to add the proper 'bind' lines if we think this *should* work..

> The Msg window size and location is not remembered.

Oh yeah. That. ;)  I noticed it like once or twice, and then promptly forgot
about it because I set my window manager to remember the location, size, *and*
which virtual desktop the window should be....

If I'm understanding the code correctly, the attached patch may help.
(Basically, it uses the same 'keepPlaces' check for both branches of the
'if $state' test, hoists the test out of that if, and then simplifies the
remaining code down.

This assumes my understanding of what $state does here is *anywhere* near
reality... ;)

> If the Msg window is closed (WM "Close" operation), an attempt to display a 
> message (or send a tcl backtrace, or even Quit) ganerates a tcl backtrace, as 
> below:

Yeah, I've seen this one too.  Not sure what to do to fix it - it's rude to
ignore the WM "Close".  On the other hand, the alternative is to add a check
someplace for the window's existence and re-create it if it's gone.  This might
be tricky, I'm not sure if Widget_Toplevel and/or Exwin_Toplevel are safe to
call to re-create a window (they seem to drop side-effects all over the place).

_______________________________________________
Exmh-workers mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/exmh-workers

--- exwin.tcl	2005-01-03 18:57:59.000000000 -0500
+++ exwin.tcl.maybe	2005-01-07 16:42:23.000000000 -0500
@@ -481,18 +481,19 @@
 	}
 	return 1
     } else {
-	if {$state != "normal"} {
-	    catch {
-		if {$exwin(keepPlaces)} {
-		    wm geometry $path $exwin(geometry,$path)
-		    wm positionfrom $path user
-		} else {
-		    wm geometry $path {}
-		    wm positionfrom $path program
-		}
-		Exmh_Debug Exwin_Toplevel $path $exwin(geometry,$path)
+        catch {
+	    if {$exwin(keepPlaces)} {
+		wm geometry $path $exwin(geometry,$path)
+		wm positionfrom $path user
+	    } else {
+		wm geometry $path {}
+		wm positionfrom $path program
 	    }
+	    Exmh_Debug Exwin_Toplevel $path $exwin(geometry,$path)
+	}
+	if {$state != "normal"} {
 	    wm deiconify $path
+	}
 
             # Some window managers (KDE 3.0?) need extra coaxing
             # to get the dialog to appear on top
@@ -504,17 +505,8 @@
             # displayand it is annoying
 
             # But this raise reportedly helps
-            raise $path
+        raise $path
 
-	} else {
-	    catch {
-		if {! $exwin(keepPlaces)} {
-		    wm geometry $path {}
-		    wm positionfrom $path program
-		}
-		raise $path
-	    }
-	}
 	return 0
     }
 }

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Exmh version 2.5 07/13/2001

iD8DBQFB3wQvcC3lWbTT17ARAo0aAKD7+bs+vMR0J6r5dBMvHeJN5lmvlwCgtJ2J
nAcTu1vB/KravslUI608mUw=
=wShH
-----END PGP SIGNATURE-----