Re: pre-announce exmh-2.7.2

>>>[email protected] said:

 > > The Msg window size and location is not remembered.
 > 
 > Oh yeah. That. ;)  I noticed it like once or twice, and then promptly
 > forgot
 > about it because I set my window manager to remember the location, size,
 > *and*
 > which virtual desktop the window should be....
 > 
 > If I'm understanding the code correctly, the attached patch may help.
 > (Basically, it uses the same 'keepPlaces' check for both branches of the
 > 'if $state' test, hoists the test out of that if, and then simplifies
 > the
 > remaining code down.
 > 
 > This assumes my understanding of what $state does here is *anywhere*
 > near
 > reality... ;)

I'd hesitate to change the implementation of exwin.tcl for
remembering window locations.  That has worked for years for
all other exmh windows - what is it about the message window
that is different ?  I believe that if you use the "Dismiss"
button in the msg window then the location will be remembered
correctly.  If you want the geometry to be saved when the
user destroys the window, you need a 
  wm protocol .msgframe WM_DELETE_WINDOW {Exwin_Dismiss .msgframe}
hook that calls Exwin_Dismiss

please don't "fix" exin.tcl, OK?
I've added the WM_DELETE_WINDOW hook

 > > If the Msg window is closed (WM "Close" operation), an attempt to
 > display a 
 > > message (or send a tcl backtrace, or even Quit) ganerates a tcl
 > backtrace, as 
 > > below:
 > 
 > Yeah, I've seen this one too.  Not sure what to do to fix it - it's rude
 > to
 > ignore the WM "Close".  On the other hand, the alternative is to add a
 > check
 > someplace for the window's existence and re-create it if it's gone.
 > This might
 > be tricky, I'm not sure if Widget_Toplevel and/or Exwin_Toplevel are
 > safe to
 > call to re-create a window (they seem to drop side-effects all over the
 > place).

Exwin_Dismiss will be perfect because it'll unmap the window.
However, you need something to re-show the menu and position it,
which is the Exwin_Toplevel command.

I'll fiddle with this.

But, please consider 2.7.2 frozen.  If you have lingering bug
requests or features, etc., etc., then you'll need to supply
patches and wait patiently.  My limited hacking budget is about
used up and I want to get this out the door.

--
Brent Welch
Software Architect, Panasas Inc
Delivering the premier storage system for scalable Linux clusters

www.panasas.com
[email protected]