*tap tap* this thing on? exmh and TK 8.5 indigestion

Well, I finally went digging into why the Exmh log window would stop working
halfway through startup.. and I finally found it, but I didn't like the answer.

It was throwing in the 'catch' clause in ExmhLog, on this line:

        $exmh(log) insert end [clock format [clock seconds] -format "%H:%M:%S "]

It turned out that 'clock format' internally calls lassign... and we have an lassign
in lib/utils.tcl *that has the parameters in the opposite order than the tcl8.5 builtin*,
which causes at least 'clock format' to throw up, and heavens knows what else...

We don't use lassign heavily:

[~/src/exmh] find . | xargs grep -i lassign
./lib/html_links.tcl:    lassign {href name} [UrlGetLink $win $x $y]
./lib/html_links.tcl:    lassign {href target} [UrlGetLink $win $x $y]
./lib/html_get_http.tcl:        lassign {proxy pport} [Http_Proxy $host]
./lib/utils.tcl:proc lassign {varList value} {
./lib/html_formtag.tcl: lassign {htag param} $form(widgets,$w)
./lib/msgShow.tcl:      lassign {qt_cnt qt_str} [MsgHighlightQuoteLevel $txt]
./lib/html.tcl:    lassign {href name} [UrlGetLink $win $x $y]

Now here's the problem:  swapping the params isn't enough.  8.5 wants

lassign  [MsgHighlightQuoteLevel $txt] qt_cnt qt_str

without the { } around the variable list.  Stubbing out our lassign and using
the 8.5 one was all of 10 minutes work.  However,  I admit not being sure how
to fix our local lassign to be 8.5 compatible (there can be a variable number
of variables).

The simple fix is to just punt on tcl 8.4 and earlier, use the 8.5 version, and
raise the requirement to tcl 8.5, which came out over 3 years ago.  Do we
have enough people who still use 8.4 that I need to fix our lassign to provide
support for the 8.4 crew?

_______________________________________________
Exmh-users mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/exmh-users

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Exmh version 2.5 07/13/2001

iD8DBQFMdg9JcC3lWbTT17ARAg+2AKClRJF0iRGxnnMjEnnn9K37dvqf3gCdGJKo
FJ9FnmEOxN4I0Y5izNomiYY=
=QGm/
-----END PGP SIGNATURE-----