Re: svn commit: r12136 - trunk/subversion/libsvn_client

"C. Michael Pilato" <[email protected]> 02 Dec 2004 22:38:55 -0600
Newsgroups gmane.mail.eyebrowse.devel,gmane.comp.version-control.subversion.svn
Message-ID <m3eki8j8rk.fsf__1238.37676733292$1102049009$gmane$org@localhost.localdomain>
[email protected] writes:

> Author: philip
> Date: Thu Dec  2 21:20:00 2004
> New Revision: 12136
> 
> Modified:
>    trunk/subversion/libsvn_client/ra.c
> Log:
> Add a bit of sanity checking, and get rid of a bit of silly disk IO.
> 
> * subversion/libsvn_client/ra.c (set_wc_prop): Make sure there is a
>   versioned entry before setting the property.

See my mail to the dev-list about why this bug exists.  I hadn't
thought of this solution.  But now that you mention (by way of making)
it, this seems a pretty safe thing to do.  It will likely mean that
switched working copies made with 1.2 clients against 1.0 or 1.1
servers will have no dav wcprops, but that's only a one time
performance hit.

(Heh.  In fact, this makes me wonder why we bother doing the resource
walk during 'svn switch' at all -- we really could speed up switch by
*not* doing it, though at the cost of subsequent operations fetching
wcprops on an as-needed basis.)