Re: svn commit: r12136 - trunk/subversion/libsvn_client

"C. Michael Pilato" <[email protected]> writes:

> [email protected] writes:
>
>> Author: philip
>> Date: Thu Dec  2 21:20:00 2004
>> New Revision: 12136
>> 
>> Modified:
>>    trunk/subversion/libsvn_client/ra.c
>> Log:
>> Add a bit of sanity checking, and get rid of a bit of silly disk IO.
>> 
>> * subversion/libsvn_client/ra.c (set_wc_prop): Make sure there is a
>>   versioned entry before setting the property.
>
> See my mail to the dev-list about why this bug exists.  I hadn't
> thought of this solution.  But now that you mention (by way of making)
> it, this seems a pretty safe thing to do.  It will likely mean that
> switched working copies made with 1.2 clients against 1.0 or 1.1
> servers will have no dav wcprops, but that's only a one time
> performance hit.

No, it still errors out when it tries to write the wrong props file.
Before this change I got this error

$ svn sw http://svn.collab.net/repos/svn/trunk/tools/dev tools/dev
../svn/subversion/libsvn_wc/lock.c:642: (apr_err=155005)
svn: Working copy 'tools/iz' not locked

now I get

$ svn sw https://svn.collab.net/repos/svn/trunk/tools/dev tools/dev
../svn/subversion/libsvn_client/ra.c:179: (apr_err=200005)
svn: 'tools/random-commits.py' is not under version control

and it happens earlier, before the client has written spurious wcprops
into tools/.svn/wcprops/ for files in tools/dev/.

I supose we could catch/ignore the error somewhere (libsvn_ra_dav
perhaps) if that's the only thing going wrong.  I don't understand the
problem sufficiently to determine whether ignoring the error is safe.

-- 
Philip Martin