Re: getmail failing for messages with invalid uncode

Michael Grant <[email protected]> Sun, 17 Oct 2021 07:18:56 -0400
Newsgroups	gmane.mail.getmail.user
Message-ID	<[email protected]>
> I don't know if there is a "they".  Roland appears to have run getmail through
> the 2to3 converter and then started hacking in fixes until it ran.  Some of
> his changes have worked, some have introduced bugs, and others are bugs that
> no one has reported yet because they're in lesser-used features.

I see.  Well, I probably would have started here too to be honest.

> > line but in Python 3.  There's some chunks of code that differe but
> > these may be just the different base versions.  My initial assessment
> > here is with some cooperation, maybe things could be merged quite
> > quickly.
> 
> You don't know what you're talking about; this isn't your codebase.  It's
> mine, and the state of "getmail6" is in no way ready for integration into
> getmail.  I have given specific, detailed instructions on how it could be
> integrated; that hasn't happened yet.

Ok.

> > I know Charles, you want to refactor it and clean it up when you move
> > to python 3 and that's great.
> 
> It's my choice.
> 
> > How terrible would it be if you and Roland took the intermediate step to
> > work together fully get to Python 3 for now
> 
> In my judgement?  That reduces to "take getmail6 as is now" and that is an
> awful idea.  It will cause me, and getmail users, untold pain.  And my
> judgement is the one that matters in this case.

In a way true, you're right, it does touch a lot of the code.  Quite a
lot of the changes do seem to be "boilerplate" like changes though.

Did you ever try running it through the 2to3 converter yourself?

> > Maybe there is something that can be done to look over it and see if the
> > logic
> 
> I have no idea if you're a programmer/software engineer, or if you maintain
> any popular free software packages, or what.  However...

Actually I have been through the code.  A couple years ago I added a
hack to read the mailbox flags for something I was working on but in
the end I abandonded it.  I thought about contributing it back but
it's too non-standard.

> You keep proposing things which put work on *my* plate but which bring no
> benefits to me.

Well, I didn't create this situation either, I was just trying to find
a way forward.

> I'll turn it around: if you want to fork getmail, or work with Roland on his
> fork, and then send me nice, clean, self-contained, single-feature,
> compatible, high-quality documented patches for inclusion into getmail which
> gradually migrate it to a codebase that is Python-2.7 and Python-3 compatible,
> then I will be happy to review them and integrate them.

Hmm, if anyone were to do this with anyone, it would be with *you*
because you are the one who has to ultimately accept it.  I'm
definitely not a Python expert.  However, I think I see what you want
now.
signature.asc (application/pgp-signature, 833 B)