Re: getmail failing for messages with invalid uncode

Michael Grant <[email protected]> wrote:
> > Roland appears to have run getmail through the 2to3 converter [...]
> 
> I see.  Well, I probably would have started here too to be honest.

Sure, it's obvious.  And on small scripts the results can be ... well, not
pretty, but okay enough to use.  On larger projects the results can be not
great at all - you basically have to refactor and clean up the whole thing
just to make it readable.

> Did you ever try running it through the 2to3 converter yourself?

Do you seriously have to ask that?  You really think I wouldn't have done
that?

Yes, of course I did that.  And the resulting code is not something I would be
proud to put my name on.

> > if you want to fork getmail, or work with Roland on his fork, and then
> > send me [...] patches 
> 
> Hmm, if anyone were to do this with anyone, it would be with *you* because
> you are the one who has to ultimately accept it.

I'm happy to offer advice to someone running into specific issues doing this
sort of work, but they don't have to partner with me to do it.  You
(generically; whoever's doing this) generate the patches the way I said and
send them to me, one at a time.  I review them, we can iterate if there are
things I think could be improved, and then move on the next one.

I don't *have* to be involved until that submission.

Charles
-- 
-----------------------------------------------------------------------
Charles Cazabon
GPL'ed software available at:               http://pyropus.ca/software/
-----------------------------------------------------------------------