Re: New release of courier packages

This is a MIME-formatted message.  If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_cm0.netlabit.sk-41817-1761308190-0001-2
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Fri, 24 Oct 2025 13:23:00 +0200
Milan Obuch <[email protected]> wrote:

> On Fri, 24 Oct 2025 07:16:54 -0400
> Sam Varshavchik <[email protected]> wrote:
> 
> > Milan Obuch writes:
> >   
> > > ../rfc2045/rfc2045.h:3227:46: error: use 'template' keyword to
> > > treat 'headers' as a dependent template name
> > >  3227 |                 typename
> > > rfc2045::entity::line_iter<crlf>::headers< |
> > >                                     ^ |
> > >                                template 4 warnings and 1 error
> > > generated. gmake[2]: *** [Makefile:663: reformime.o] Error 1
> > > gmake[2]: Leaving directory
> > > '/work/usr/ports/mail/courier/work/courier-1.5.1/ libs/rfc2045'
> > > gmake[1]: *** [Makefile:504: all] Error 2
> > > gmake[1]: Leaving directory
> > > '/work/usr/ports/mail/courier/work/courier-1.5.1/ libs/rfc2045'
> > > gmake: *** [Makefile:475: all-recursive] Error 1
> > > *** Error code 1
> > >
> > > (Full log is 360 kB, available on request, I'd rather not spam
> > > this mailing list with it.)
> > >
> > > I built courier-1.4.1 before courier-unicode update just fine.
> > > Other packages, namely courier-unicode-2.4.0,
> > > courier-authlib-base-0.72.5, and courier-authlib-userdb-0.72.5
> > > build just fine. Any idea what I could do to fix the issue?    
> > 
> > Try changing the line in question to read:
> > 
> > 	typename rfc2045::entity::line_iter<crlf>::template headers<
> > 
> > This part was tricky, trying to get this part to compile on all the
> > versions of gcc that were available to me.
> > 
> > The current version compiles without any warnings on versions of
> > gcc starting from the current 15, and going back to gcc 10. Which
> > compiler are you using?  
> 
> FreeBSD uses clang, exact compiler version depends on OS version. On
> the box I did the test:
> 
> # cc -v
> FreeBSD clang version 19.1.7
> (https://github.com/llvm/llvm-project.git llvmorg-19.1.7-0-gcd708029e0b2) Target: x86_64-unknown-freebsd14.3
> Thread model: posix
> InstalledDir: /usr/bin
> 
> I'll test your proposal and report back my findings.
>

Two files needed the same type of patch, then build succeeds. All
attached here for reference. If you could incorporate them somehow,
great. If not, no big deal for me, I can do patching locally.

Now I am going to test the functionality.
Thanks for help.

Regards,
Milan

--=_cm0.netlabit.sk-41817-1761308190-0001-2
Content-Type: text/patch; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=patch-libs__rfc2045__rfc2045.h

--- libs/rfc2045/rfc2045.h.orig	2025-10-05 18:47:55.000000000 +0200
+++ libs/rfc2045/rfc2045.h	2025-10-24 13:26:29.985150000 +0200
@@ -3224,7 +3224,7 @@
 
 	if (decode_header)
 	{
-		typename rfc2045::entity::line_iter<crlf>::headers<
+		typename rfc2045::entity::line_iter<crlf>::template headers<
 			src_type> parser{e, src	};
 
 		parser.name_lc=header_name_lc;

--=_cm0.netlabit.sk-41817-1761308190-0001-2
Content-Type: text/patch; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=patch-libs__rfc2045__testsuitecpp.C

--- libs/rfc2045/testsuitecpp.C.orig	2025-10-03 19:53:41.000000000 +0200
+++ libs/rfc2045/testsuitecpp.C	2025-10-24 14:00:53.643970000 +0200
@@ -19,7 +19,7 @@
 		auto b=s.begin();
 		auto e=s.end();
 
-		typename rfc2045::entity::line_iter<crlf>::iter<
+		typename rfc2045::entity::line_iter<crlf>::template iter<
 			std::string_view::iterator,
 			std::string_view::iterator
 			>

--=_cm0.netlabit.sk-41817-1761308190-0001-2
Content-Type: text/patch; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=patch-libs__rfc2045__testsuitecpp2.C

--- libs/rfc2045/testsuitecpp2.C.orig	2025-09-10 11:00:08.000000000 +0200
+++ libs/rfc2045/testsuitecpp2.C	2025-10-24 14:02:10.528663000 +0200
@@ -217,7 +217,7 @@
 	auto b=std::istreambuf_iterator<char>{ss};
 	auto e=std::istreambuf_iterator<char>{};
 
-	typename rfc2045::entity::line_iter<crlf>::iter<
+	typename rfc2045::entity::line_iter<crlf>::template iter<
 		std::istreambuf_iterator<char>,
 		std::istreambuf_iterator<char>
 		> iter{b, e};
@@ -310,7 +310,7 @@
 	auto b=std::istreambuf_iterator<char>{ss};
 	auto e=std::istreambuf_iterator<char>{};
 
-	typename rfc2045::entity::line_iter<crlf>::iter<
+	typename rfc2045::entity::line_iter<crlf>::template iter<
 		std::istreambuf_iterator<char>,
 		std::istreambuf_iterator<char>
 		> iter{b, e};
@@ -488,7 +488,7 @@
 	auto b=std::istreambuf_iterator<char>{ss};
 	auto e=std::istreambuf_iterator<char>{};
 
-	typename rfc2045::entity::line_iter<crlf>::iter<
+	typename rfc2045::entity::line_iter<crlf>::template iter<
 		std::istreambuf_iterator<char>,
 		std::istreambuf_iterator<char>
 		> iter{b, e};

--=_cm0.netlabit.sk-41817-1761308190-0001-2
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--=_cm0.netlabit.sk-41817-1761308190-0001-2
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
courier-users mailing list
[email protected]
Unsubscribe: https://lists.sourceforge.net/lists/listinfo/courier-users

--=_cm0.netlabit.sk-41817-1761308190-0001-2--