Re: [PATCH] Drop -pedantic from CFLAGS

Alejandro Colomar via Mutt-dev <[email protected]> Fri, 13 Feb 2026 17:27:28 +0100

Newsgroups	gmane.mail.mutt.devel
Message-ID	<aY9Q6q2uYBAQu5Bp@devuan>

On 2026-02-13T17:07:35+0100, Rene Kita wrote:
> On Fri, Feb 13, 2026 at 05:57:28PM +0800, Kevin J. McCarthy wrote:
> > On Fri, Feb 13, 2026 at 09:27:43AM +0100, Rene Kita wrote:
> > > Consensus is that it does more harm than good.
> > > ---
> > > configure.ac | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Whoops, I apologize.  I didn't express myself clearly.  At the time I
> 
> No worries.
> 
> > thought we were talking about disabling it in the sr.ht CI builds that were
> > causing you to contort to get working with -Werror also enabled.
> > 
> > While I'm not absolutely against removing -pedantic, my limited
> > understanding was that "-Wall -pedantic" was a pretty good combination to
> > ensure code is more compatible with other compilers and environments.
> > 
> > I'd like to hear other opinions before we completely drop it from our
> > default compiler options.
> 
> I prefer removing it, but am OK with keeping it also. -pedantic is too
> strict. To make sure we are compatible with other compilers we should
> actually build with them.
> 
> But CI should reflect the regular build. The only reason I manually
> added the CFLAGS in the builds was that I did not manage to keep the
> defaults _and_ add -Werror to them (and I decided that I already
> invested too much time and doing it manually was the better solution for
> now).
> 
> IMHO, CI run should always run with -Werror to make any new warning a
> hard stop. Then after reviewing it we can add an exception.

+1

-- 
<https://www.alejandro-colomar.es>

signature.asc (application/pgp-signature, 833 B)