Re: [RFC] Some sr.ht CI tweaking

Daniel Tameling <[email protected]>
Newsgroups gmane.mail.mutt.devel
Message-ID <[email protected]>
On Fri, Feb 13, 2026 at 10:57:19AM +0800, Kevin J. McCarthy wrote:
> 
>  #ifdef iswupper
>  # undef iswupper
>  #endif
> +#ifdef wcwidth
> +# undef wcwidth
> +#endif
>  size_t wcrtomb (char *s, wchar_t wc, mbstate_t *ps);
>  size_t mbrtowc (wchar_t *pwc, const char *s, size_t n, mbstate_t *ps);
>  int iswprint (wint_t wc);
> 

I can confirm that this fixes the compilation with --without-wc-funcs on FreeBSD.

> > Honestly, wchar.h and wctype.h are nowadays part of POSIX and the C
> > standard, and have been for a long time. The workaround isn't really
> > needed anymore. If somebody disagrees, they should step up and maintain
> > the code. Your limited time is better spend elsewhere.
> 
> That would nice.  I wonder if we could mark --without-wc-funcs as deprecated
> in the 2.4.0 release and rip this stuff out in the 2.5.0 release?  I hear
> Steffen's objection, but isn't it reasonable to expect a system to have the
> wc functions by now?
> 

I think wcwidth is available on all major platforms. Even if not, having a workaround only for this function would already greatly simplify the code. And to find out if anybody still needs the workarounds, the easiest method is to deprecate them and see if anybody complains. So I support that.

@alejandro: thank you for the detailed explanation.

Best regards,
Daniel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.