Re: [PATCH] Set up 'make check' and add tab scanner.

Rene Kita <[email protected]>
Newsgroups gmane.mail.mutt.devel
Message-ID <[email protected]>
On Mon, Feb 16, 2026 at 12:59:17PM +0800, Kevin J. McCarthy wrote:
> Add target 'tabcheck', running a quick perl scan of the C source code
> for tabs.  Note the double dollar sign $$ARGV is because of
> Makefile.am escaping.
> 
> Add check-security to the top level check-local target.
> 
> Add manual.xml validation to the doc/check-local target.
> 
> Don't add shellcheck target for now, because it appears to flag lots
> of unimportant issues.  Perhaps someone more familiar with this tool
> can fix it up and add it to check-local later on.
> ---
[snip]
> @@ -221,4 +223,8 @@ update-doc:
>  shellcheck:
>  	(find . -name \*.sh && echo "gen_defs muttbug prepare") |
>  	xargs shellcheck --exclude=SC2003,SC2006,SC2086,SC2162,SC2046

Do you mean that 'unimportant issues' which got suppressed with this
--exclude? I.e. we should be able to run shellcheck without the
--exclude?

I'll prepare a patch.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.