Re: clang-format output in branch kevin/clang-format

On Sun, Mar 22, 2026 at 05:45:10PM +0800, Kevin J. McCarthy wrote:
>The output is pretty much what I mentioned earlier.  There are some 
>places where the formatting isn't great.  But (IMO) overall it 
>smoothed things over for the variations in the code.  I'll let you 
>judge though.

I've let this sit all week, so hopefully that's long enough to give 
everyone a chance to chime in.

I've decided for now to drop the clang-format cleanup.  If its output 
was better quality, it would have been nice to have.  But it behaves 
weirdly, and if we leave the .clang-format config in there, I'm afraid 
we'll be encouraging source files to be automatically reformatted by 
potential patch submitters.

However, I've spent this evening scripting two formatting changes I 
would like to make manually.  One is fixing 'int* foo' to 'int *foo' in 
those places in the code that do that.  Two is removing the space before 
parens in funcalls.

I need tomorrow, and perhaps Sunday to go through the results and clean 
some places up, but I expect to send patches Sunday or Monday.  It's not 
as awesome as a full format tidy, but I think those two things will have 
a nice overall effect on the code.

-- 
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEiXWpszqjeRA4XFMIre92hIAxa9oFAmnGgIAACgkQre92hIAx
a9pu7RAA2FocklGVfeRIbQg6/wDdac2bm1pP6elIhQ+1V1TooMRtD40AEogRrDfj
+TKxa91N+YsvQfwVtQonmin2r8+CUlmz30M6M7qCHM0AY8BlhTLSGtENLlkZLVu3
AfLiWHvBnT//3gB6Ghl8jBlBLr3n01Uf70R+NXjLvUeV7cfFZ1R0ydMjbbBpU9VN
klEPLFPkc2YlCTazCrlSoP6cHMYK9YmQmmVCOhiU6x6x+sIo+yreYSGVaqVf/xrK
PxbhgdCXr3dYsOebBvx4Yia9TAKQCO46AEY/D4s1JhHu/zxgDbIpnH+wPg7Y7ysw
KKhhyWg8sNEJd94n/7VgVHirbzCwUUljESGt33uUzQiY561NVjYqvbnGjOzYtYKp
h2oD7EvrqDkfMDmtHJwLsWgXZ3lqcYPw5RSGkbU47eZpP/32BGC8o/eqNs6jjO3n
dV4+DoRAFgupMwIFxlLTpOc/Qv1kGs2egkOF5s92edxw4evq/9Q3aYUSFJcKfPFr
d2DPl489gGJllLmR7ZpvqIMuIDjaoMXixRNqQKHCFXYtzIq4uA4tRe2v61fPhryP
nfrIOCcTuJF5TChigspNaxFf2WO+1bYVL/IfBtwub8AADJvof9OlFltM2EqXgFUy
T0YHInNpmZ0IcLtWdXtfQ+QHLkXTk2k53nqIE7aMnp9YgDiZzUg=
=OEAw
-----END PGP SIGNATURE-----