Re: clang-format output in branch kevin/clang-format

Alejandro Colomar via Mutt-dev <[email protected]> Fri, 27 Mar 2026 15:06:24 +0100

Newsgroups	gmane.mail.mutt.devel
Message-ID	<acaOzHkpUMg4wGS0@devuan>

Hi Kevin,

On 2026-03-27T21:05:04+0800, Kevin J. McCarthy wrote:
> On Sun, Mar 22, 2026 at 05:45:10PM +0800, Kevin J. McCarthy wrote:
> > The output is pretty much what I mentioned earlier.  There are some
> > places where the formatting isn't great.  But (IMO) overall it smoothed
> > things over for the variations in the code.  I'll let you judge though.
> 
> I've let this sit all week, so hopefully that's long enough to give everyone
> a chance to chime in.
> 
> I've decided for now to drop the clang-format cleanup.  If its output was
> better quality, it would have been nice to have.  But it behaves weirdly,
> and if we leave the .clang-format config in there, I'm afraid we'll be
> encouraging source files to be automatically reformatted by potential patch
> submitters.
> 
> However, I've spent this evening scripting two formatting changes I would
> like to make manually.  One is fixing 'int* foo' to 'int *foo' in those
> places in the code that do that.  Two is removing the space before parens in
> funcalls.
> 
> I need tomorrow, and perhaps Sunday to go through the results and clean some
> places up, but I expect to send patches Sunday or Monday.  It's not as
> awesome as a full format tidy, but I think those two things will have a nice
> overall effect on the code.

+1  Thanks!


Have a lovely day!
Alex

-- 
<https://www.alejandro-colomar.es>

signature.asc (application/pgp-signature, 833 B)