Re: [PATCH 0/4] Clean up header->env checks and maildir parsing.

"Kevin J. McCarthy" <[email protected]> Sat, 18 Jul 2026 20:22:43 +0800
Newsgroups gmane.mail.mutt.devel
Message-ID <[email protected]>
--7ZM4XxHwZBKsuQjb
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jul 18, 2026 at 11:12:03AM +0200, Rene Kita wrote:
>On Fri, Jul 17, 2026 at 09:52:50AM +0800, Kevin J. McCarthy wrote:
>> The main focus of this patch set was removing unneeded hdr->env NULL
>> checks in a few places.  This has been on my TODO list for a while.  I
>> don't like to see those tests unless there is a good reason, and I
>> suspected they were "voodoo" safety checks.
>
>LGTM, but untested.

Thanks for taking a look, Rene!

I'll give a couple more days, in case anyone else wants to review, then=20
will push it up to master.

--=20
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

--7ZM4XxHwZBKsuQjb
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEiXWpszqjeRA4XFMIre92hIAxa9oFAmpbcBMACgkQre92hIAx
a9qIXBAAnu6VIa+y4vde+DdFF9mp1ZYrdLy7/ZtsIPmltcwFSL+z5NOMQUBkSoy5
KctAJtHHvYGkIeFSGDbkN1ugENVauw7WRp3fXsjphph/d/soRYSMeX0icDQMm84K
gl4k/Uz06vXJBrkQOHSPqh/ovb6Y7xVxE8YflkYZuJfl6DiVW1yNMB3Ri5cCk0Uf
UW4D3CEuisC29zS+tm30ZlICH4eBGsFvlEj/R6TJY3+oDoNwXY4vZe7JyUQ1RCA8
9nSh03j19/mEdRqZ4VTh3Agcs2TuRWqnNfJtxp6uUwTlSEy6q/N26+kPIGNAlC45
YfacsDvgqFaVrcE7f/edncyY8lxjAoQS0NhnKHlil7xSiOZTc6j9ZkZxw/cFgiY8
iTnUbY8r3gUxM5118Vux7IZadHR56sL43QNyr+FhAC1aXpUrJMLM/B4LOvOyN7gP
3lOuCQXFUtU2TfpDpLBb9hSIwhz2iWxWuktI3h581aW8YrSllu60/6aR4eVpAI4c
8VV6ssTlF2HiXhCBWKgNFR+qJWTe37+T3Q29FaYf2hc8wEViQS9vGpY9zySXZq/N
JmsKl6QwPrhEGcMsUkP9SDmEKjby7fh/TrKVPmFQ2qAWevmsoZFSXBMGAIMExBRq
KWD0RtzG5JhbuiodxS/wesSveoDJt7+CyjE8xT/Ibg75rTcHLmc=
=PGub
-----END PGP SIGNATURE-----

--7ZM4XxHwZBKsuQjb--