Re: [PATCH 0/4] Clean up header->env checks and maildir parsing.

--blrjxvizqlgfodn7
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
From: Alejandro Colomar <[email protected]>
To: [email protected]
Subject: Re: [PATCH 0/4] Clean up header->env checks and maildir parsing.
Message-ID: <altwjDx8s-R2q794@devuan>
References: <[email protected]>
 <[email protected]>
 <[email protected]>
MIME-Version: 1.0
In-Reply-To: <[email protected]>

Hi Kevin,

On 2026-07-18T20:22:43+0800, Kevin J. McCarthy wrote:
> On Sat, Jul 18, 2026 at 11:12:03AM +0200, Rene Kita wrote:
> > On Fri, Jul 17, 2026 at 09:52:50AM +0800, Kevin J. McCarthy wrote:
> > > The main focus of this patch set was removing unneeded hdr->env NULL
> > > checks in a few places.  This has been on my TODO list for a while.  I
> > > don't like to see those tests unless there is a good reason, and I
> > > suspected they were "voodoo" safety checks.
> >=20
> > LGTM, but untested.
>=20
> Thanks for taking a look, Rene!
>=20
> I'll give a couple more days, in case anyone else wants to review, then w=
ill
> push it up to master.

I didn't say anything so far because I hadn't tested or thoroughly
checked for correctness, but it certainly looks good to me and trust you
on the quality.  If you want:

Acked-by: Alejandro Colomar <[email protected]>


Have a lovely day!
Alex

>=20
> --=20
> Kevin J. McCarthy
> GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA



--=20
<https://www.alejandro-colomar.es>

--blrjxvizqlgfodn7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEES7Jt9u9GbmlWADAi64mZXMKQwqkFAmpbcPwACgkQ64mZXMKQ
wqmKew//aSdQwA3Mrijed6ryvxPUAccU5mZw9PKivTdDSx2glZ7LeHa4RLOtIV7I
K9/fGWTEmHdz7lP6KQZIysMUAXoKks0rjCvk9rSKrocKMSyLH5hJjuXbkUTIJmb6
PBE22F0k1qE0bbRa0t6ZG+it4infZLAxUuR0z4t+o138qzqaoMWzsbOpKcEk/tVX
RixwdFkluaJIzyR3EbQj4QXagxhn5TXXC5x39e1J2AOa3HtKa4a6kvy6k3RBrkt7
X3fiXgaRDfX2VoYlr5tGSog18Hw8K1C8gW2gklF790Xn2ChqOmOgsYmxTH7IGK2i
M7fyeMclwQg1tvrEWYnHTWz2mlc5Ld7lmiTiXiGKWI+4MfM6riK/1PiTYJ4ao0AD
erf8XxJRo6szi7dDLBudbAt4kknanimR4dFNcWlEbGk76hks2EGZCb1b2a/imGwg
Us9qOwJwYPOGwcYJWKAVTo7CDEFANaQPi3dTmLVDh8AkNMJ6oqqDG9cL55Vc2JeH
6rQyQbQjvTi7HcC5dAhwdt6BYgmcRA7Qm2v74aZhezuTVixwiVKUsWPJl86qtBcg
g8P651CtKYbBXNzue3Ww3Uuo8f2tr9/IPC7oJB0zdCzC/ikMPFIrpfHPBOLK4DK3
gRrMfEg+JWPjQ1ax1YxtikscrACv74MHf+DrId8zEit0jx80F+g=
=CvTe
-----END PGP SIGNATURE-----

--blrjxvizqlgfodn7--