Re: [PATCH 0/4] Clean up header->env checks and maildir parsing.

"Kevin J. McCarthy" <[email protected]> Sat, 18 Jul 2026 20:48:26 +0800
Newsgroups gmane.mail.mutt.devel
Message-ID <[email protected]>
--GWktxKdjLhN8KSqs
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jul 18, 2026 at 02:26:36PM +0200, Alejandro Colomar via Mutt-dev wr=
ote:
>Hi Kevin,
>
>On 2026-07-18T20:22:43+0800, Kevin J. McCarthy wrote:
>> On Sat, Jul 18, 2026 at 11:12:03AM +0200, Rene Kita wrote:
>> > On Fri, Jul 17, 2026 at 09:52:50AM +0800, Kevin J. McCarthy wrote:
>> > > The main focus of this patch set was removing unneeded hdr->env NULL
>> > > checks in a few places.  This has been on my TODO list for a while. =
 I
>> > > don't like to see those tests unless there is a good reason, and I
>> > > suspected they were "voodoo" safety checks.
>> >
>> > LGTM, but untested.
>>
>> Thanks for taking a look, Rene!
>>
>> I'll give a couple more days, in case anyone else wants to review, then =
will
>> push it up to master.
>
>I didn't say anything so far because I hadn't tested or thoroughly
>checked for correctness, but it certainly looks good to me and trust you
>on the quality.  If you want:
>
>Acked-by: Alejandro Colomar <[email protected]>

Thank you also, Alex!

--=20
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

--GWktxKdjLhN8KSqs
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEiXWpszqjeRA4XFMIre92hIAxa9oFAmpbdhoACgkQre92hIAx
a9rMrBAAy83wjwx+DXX7p7fsxUI6l8WV93cGH7gZwePAjRJJo90X4kbDhufYWe5C
9PLF3uvpQddaeANvvTGwaUc20Js5MhGqEc30erP+XNb4/BuZrNf9SEOtWwG+3/Xa
Os0BA2R/n+k2QT1OF4+4m9XfpLdLKbfYZO3UxqbPIGS2jNBmB6M5eVExFdMBqnOh
poYmVUsH2AICnwSd6P6e4bkwCoK8TUEMWUfN3okmDCWUcVpcxqlKAgABf7LhrLfG
uE4QOJsea54lf0tvrvnVLmAocUTqxynJjSOgTnktDsYSXLn+IjsM3pOsQPpVUsuR
Gh3s852OJbFyfl1CWyYTB9sWa9RJ9dc1OmQmufi/9bW+DkfTGMYHCmXvDpzkKzYM
OztOypefn3HYNn47SRkhsh6uq7/L0pvRIFIzp0GXTxIVlbGj6edjVMK1lzM8YJfY
02daYkRqi7FsmW4c7GtwtSR6IMTgejP4PY4Lvm1N3ChzSZh7YqnmHZS+pKMOrWns
UxlXYZ27bK/Psb8bqOsIL7vOFtRcMExmeHif0zGd/lA5F2Dxn5rBidbpLJm3k3Ow
sqGVhSrxsin0AlU05E09/F5HDmjpO0DP0esZxmFd66l+KxR3rWsplgIXbGzfA+XE
8H+AAFBTspDW2xuRJZuaUVyN8LWmIIF+T+mLhWiDUg7G8BbANoI=
=nyLu
-----END PGP SIGNATURE-----

--GWktxKdjLhN8KSqs--