Re: [PATCH 0/4] Clean up header->env checks and maildir parsing.

"Kevin J. McCarthy" <[email protected]> Sun, 19 Jul 2026 14:24:00 +0800
Newsgroups gmane.mail.mutt.devel
Message-ID <[email protected]>
--5eEbbISW+zorWT3H
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 17, 2026 at 09:52:50AM +0800, Kevin J. McCarthy wrote:
>Kevin J. McCarthy (4):
>  Fix memory leaks on error in main() and mmdf_parse_mailbox().
>  Remove unneeded header->env checks.
>  Simplify maildir_delayed_parsing().
>  Remove maildir header_parsed bit.

I pushed patch 1 and 2 up to master.

But I chickened out on removing the "skip headers" optimization before
the sort in patch 3.

I'm testing another patch right now that still cleans up the function:=20
removing the DO_SORT() macro and skip_duplicates() function, moving the=20
sort before the loop, removing the header_parsed bit, and adding some=20
comments.  But it keeps the "skip entries without headers logic" so that=20
I don't introduce any possible slowdowns to the code.

I'll send it to the list after a couple days of dogfood'ing it myself.

--=20
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

--5eEbbISW+zorWT3H
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEiXWpszqjeRA4XFMIre92hIAxa9oFAmpcbYAACgkQre92hIAx
a9rGTw/9FjynWJgG7exc/iZbo9eHMVoYrO9rWLmS8KmyuzhvQ7HqY2vv4ia4cT+e
KXoJZ5aaOVhBd6DdakLSGer3obztdc3qN0HIZKRvexjE2E2LGHaifjI9wXqb+Bun
0QBZEWFzqnYYokVsnwB89P5huL+U3XRDaIYVKM9NrIDkks9K2D8U1zO3rXcMEvFf
/SDpMsjn56ZlTOFD7QJ3TdiHj9QARh7DENgj0IO98kQMabC1rkGvbOJVeDUE1br9
U3lNt0DxHLgq3bxzuORWm/dtkvin0zYt+HUULCUpFhWl+pbgxVCMMpKiAUyZAidP
TH/Xtz8QFomCQmn9lCkza1wnKE1VqIFBv3A92jcC8XRUC5TRBJLkvIzPEDSoq88p
+XkC6o7QKmoRRjzOp3Bk3/n7rP+dr1+pE1Ua2kzBsIpKhN6RT5VZ+Kvms1TFsfV2
GZpjHXGmSYSaRND21vWDUqJvJSPriRl5K1qH2BqPHKCGiEp76oqLAwd4xphK7kVn
drxb0VO44GzYsl2wvdrRxLjVLfbGLpOLcYyBZQ1vAG4WR6IGlhug4FQRo9wYNIna
ap8+PIdClbjmL5i8djeFr5ToO7mQV2og/KsFO7Qr3fAz8amHWc1CxztBN9GXpmeK
oFA/WWLEkXqxZ/bnC+hGYnHpt2SIl5PebjxmAhRKDos+bpuKcJY=
=OgTV
-----END PGP SIGNATURE-----

--5eEbbISW+zorWT3H--