Re: Re: test failures for 2.2 on Debian buildd's

"Harald Jenny via nullmailer" <[email protected]> writes:

> Dear David,
>
>> Eventually I narrowed this down to (what I believe is) a racy test.
>> test/authtest-smtp.sh removes it's input file, but since it is run by
>> tcpserver, this happens in a different process than tests/smtp-auth. It
>> seems that in certain circumstances this can cause a race condition
>> where the previous test removes the smtp-response file wanted for the
>> current test. The obvious patch is attached.
>
> at least in my compile environment my error still pops up with your new
> version of nullmailer.
>

Yes, I think there are multiple race conditions. The one I patched is
just much easier to trigger. On my amd64 laptop it takes about 100 tries
to trigger the failer on "auth login success". As documented at [1], the
second failure seems to involve the client receiving a SIGPIPE. You can
test this by

% cd test && bash -x tests/smtp-auth

near the end it should say something like "'[' 141 -eq 0 ']'"

[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917197