[pfx] Re: Patch service_name RO logic (was: snapshot 3.12-20260508 postscreen segfault)
Viktor Dukhovni via Postfix-users <[email protected]> Sun, 10 May 2026 20:53:42 +1000
| Newsgroups | gmane.mail.postfix.user |
|---|---|
| Message-ID | <[email protected]> |
> On 10 May 2026, at 5:16 pm, Florian Piekert via Postfix-users <[email protected]> wrote: > > Hello Wietse and Viktor, all, > > I noticed with the change from snapshot 3.12-20260506 to 3.12-20260508 I see > > May 10 08:58:49 theater kernel: postscreen[1142630]: segfault at 0 ip 00007fd45718b7dd sp 00007ffefff0daf8 error 4 in libc.so.6[18b7dd,7fd457028000+188000] likely on CPU 4 (core 5, socket 0) > May 10 08:58:49 theater kernel: Code: 00 00 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 89 f8 48 89 fa c5 f9 ef c0 25 ff 0f 00 00 3d e0 0f 00 00 0f 87 33 01 00 00 <c5> fd 74 0f c5 fd d7 c1 85 c0 74 57 f3 0f bc c0 c5 f8 77 c3 66 66 > May 10 08:59:08 theater kernel: postscreen[1143920]: segfault at 0 ip 00007e70e718b7dd sp 00007fff4e651138 error 4 in libc.so.6[18b7dd,7e70e7028000+188000] likely on CPU 0 (core 0, socket 0) > May 10 08:59:08 theater kernel: Code: 00 00 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 89 f8 48 89 fa c5 f9 ef c0 25 ff 0f 00 00 3d e0 0f 00 00 0f 87 33 01 00 00 <c5> fd 74 0f c5 fd d7 c1 85 c0 74 57 f3 0f bc c0 c5 f8 77 c3 66 66 > May 10 08:59:49 theater kernel: postscreen[1144999]: segfault at 0 ip 000073d55a18b7dd sp 00007ffe396aed88 error 4 in libc.so.6[18b7dd,73d55a028000+188000] likely on CPU 7 (core 1, socket 0) > May 10 08:59:49 theater kernel: Code: 00 00 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 89 f8 48 89 fa c5 f9 ef c0 25 ff 0f 00 00 3d e0 0f 00 00 0f 87 33 01 00 00 <c5> fd 74 0f c5 fd d7 c1 85 c0 74 57 f3 0f bc c0 c5 f8 77 c3 66 66 > > across my ubuntu 24.04 machines consistently. > > "downgrade" removed the problem. Claude reports two typos in the latest snapshot, with the first masking the second. Patch attached. -- Viktor. _______________________________________________ Postfix-users mailing list -- [email protected] To unsubscribe send an email to [email protected]
service_name.diff
(application/octet-stream, 3 KB)
diff --git a/src/master/dgram_server.c b/src/master/dgram_server.c
index 426fc7cd9..7400a7e5f 100644
--- a/src/master/dgram_server.c
+++ b/src/master/dgram_server.c
@@ -448,5 +448,5 @@ NORETURN dgram_server_main(int argc, char **argv, DGRAM_SERVER_FN service,...)
}
- /* Read-only parameters must not be changed with '-o name=value'.
+ /* Read-only parameters must not be changed with '-o name=value'. */
set_mail_conf_str(VAR_PROCNAME, var_procname);
- var_servname = mystrdup(servname);
+ var_servname = mystrdup(service_name);
set_mail_conf_str(VAR_SERVNAME, var_servname);
diff --git a/src/master/event_server.c b/src/master/event_server.c
index f70f124a4..8893430e9 100644
--- a/src/master/event_server.c
+++ b/src/master/event_server.c
@@ -727,5 +727,5 @@ NORETURN event_server_main(int argc, char **argv, MULTI_SERVER_FN service,...)
}
- /* Read-only parameters must not be changed with '-o name=value'.
+ /* Read-only parameters must not be changed with '-o name=value'. */
set_mail_conf_str(VAR_PROCNAME, var_procname);
- var_servname = mystrdup(servname);
+ var_servname = mystrdup(service_name);
set_mail_conf_str(VAR_SERVNAME, var_servname);
diff --git a/src/master/multi_server.c b/src/master/multi_server.c
index 33f0012e0..55255e125 100644
--- a/src/master/multi_server.c
+++ b/src/master/multi_server.c
@@ -705,5 +705,5 @@ NORETURN multi_server_main(int argc, char **argv, MULTI_SERVER_FN service,...)
}
- /* Read-only parameters must not be changed with '-o name=value'.
+ /* Read-only parameters must not be changed with '-o name=value'. */
set_mail_conf_str(VAR_PROCNAME, var_procname);
- var_servname = mystrdup(servname);
+ var_servname = mystrdup(service_name);
set_mail_conf_str(VAR_SERVNAME, var_servname);
diff --git a/src/master/single_server.c b/src/master/single_server.c
index 4c4559f60..de859f6e4 100644
--- a/src/master/single_server.c
+++ b/src/master/single_server.c
@@ -579,5 +579,5 @@ NORETURN single_server_main(int argc, char **argv, SINGLE_SERVER_FN service,...)
}
- /* Read-only parameters must not be changed with '-o name=value'.
+ /* Read-only parameters must not be changed with '-o name=value'. */
set_mail_conf_str(VAR_PROCNAME, var_procname);
- var_servname = mystrdup(servname);
+ var_servname = mystrdup(service_name);
set_mail_conf_str(VAR_SERVNAME, var_servname);
diff --git a/src/master/trigger_server.c b/src/master/trigger_server.c
index 4aca681f4..88f084ee1 100644
--- a/src/master/trigger_server.c
+++ b/src/master/trigger_server.c
@@ -561,5 +561,5 @@ NORETURN trigger_server_main(int argc, char **argv, TRIGGER_SERVER_FN service,..
}
- /* Read-only parameters must not be changed with '-o name=value'.
+ /* Read-only parameters must not be changed with '-o name=value'. */
set_mail_conf_str(VAR_PROCNAME, var_procname);
- var_servname = mystrdup(servname);
+ var_servname = mystrdup(service_name);
set_mail_conf_str(VAR_SERVNAME, var_servname);