[ dspam-Bug Tracker-3018120 ] spam client fails to quote period when talking to unix socke

Bug Tracker item #3018120, was opened at 2010-06-18 18:59
Message generated for change (Comment added) made by sbajic
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=3018120&group_id=250683

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: daemon
Group: v3.9.0
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Torsten Hilbrich (myrkr)
>Assigned to: Stevan Bajic (sbajic)
Summary: spam client fails to quote period when talking to unix socke

Initial Comment:
I'm currently testing with the Git version of dspam, commit 3f44096792a437cb8b4c8ca9647a82c2664b087c

I configure the spam to run in daemon mode and use a local socket to talk between client and server.

I noticed that for some mails I try to learn the spam client needed quite a long time to talk to the server. I straced the server and noticed the following error messages:

[pid 29967] send(4, ".", 1, 0)          = 1
[pid 29967] send(4, "\r\n", 2, 0)       = 2
[pid 29967] send(4, "503 5.0.0 Need MAIL FROM here.", 30, 0) = 30
[pid 29967] send(4, "\r\n", 2, 0)       = 2
[pid 29967] send(4, "503 5.0.0 Need MAIL FROM here.", 30, 0) = -1 EPIPE (Broken 

Looking at the source code I can see that the quoting of a single period on a line is missing in the client_process function. When such a character is encounted by the server it stops reading the message. The quoting is present in the function deliver_socket which is used when talking TCP to the LMTP port.

Here is a simple example mail that triggers the bug:

======= cut here ===============
From: <[email protected]>
To: <[email protected]>
Subject: testing

This is a text line
.
This is not read by the server.
======= cut here ===============

With best regard,

Torsten

----------------------------------------------------------------------

>Comment By: Stevan Bajic (sbajic)
Date: 2010-08-14 16:57

Message:
Hello Torsten, thanks for reporting this issue. It is fixed now in GIT.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=3018120&group_id=250683

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev