[ dspam-Bug Tracker-3055182 ] broken URLs in webui

Bug Tracker item #3055182, was opened at 2010-08-29 02:24
Message generated for change (Comment added) made by duck207
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=3055182&group_id=250683

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: webui
Group: v3.9.1
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: The Duck (duck207)
Assigned to: Stevan Bajic (sbajic)
Summary: broken URLs in webui

Initial Comment:
When you ask to display innocent mails of your history, select mails to retrain, you expect to get the same page back with your mails flaggued as retrained, but in fact you get back to the default history filter. That's boring because most people would like to just change page and retrain other mails and so on. AFAIR, it used to work well in 3.9.0, and probably early work on 3.9.1.

By reading dspam.cgi, it seems there is a mix of & and & in the URLs. I got several pages fixed with the attached patch (not sure it fixes everything).


----------------------------------------------------------------------

>Comment By: The Duck (duck207)
Date: 2010-09-29 17:01

Message:
Hello Stevan

I checked english only, but i could check french if you wish to.

I made a few minor changes to the template, like s#<br>#<br/># or
repeating the page bar on top, but nothing very intrusive, so it should not
impact on the tests.

Kind regards from DuckLand ;-)


----------------------------------------------------------------------

Comment By: Stevan Bajic (sbajic)
Date: 2010-09-29 14:34

Message:
Hello Duck,

might I ask what language you have checked with the validator? I mean what
DSPAM Web-UI language have you checked?

Kind Regards from Switzerland,

Stevan Bajic

----------------------------------------------------------------------

Comment By: The Duck (duck207)
Date: 2010-09-29 14:29

Message:
The validator did not complain for &/&amp; at all with git 6b6d8c8 and this
provided patch applied.

For the record, even if outside the scope of this issue, the validator
gave 2 errors:
* no document type declaration
* required attribute "TYPE" not specified (<script
language="javascript">)


----------------------------------------------------------------------

Comment By: Stevan Bajic (sbajic)
Date: 2010-08-29 02:53

Message:
Please check the output of the modified CGI script with the W3C validator
and tell me if that & is right or if there should be &amp; inside the HTML
documents.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=3055182&group_id=250683

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev