Re: Release DSPAM 3.9.1 ?
Stevan Bajić <[email protected]> Wed, 8 Jun 2011 22:37:20 +0200
| Newsgroups | gmane.mail.spam.dspam.devel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 08 Jun 2011 15:50:31 +0100 Carlo Rodrigues <[email protected]> wrote: Hello Carlo, > > It seems that we have now 3 votes for 'release early, release often', > > and no votes to postpone release until all/major bugs are fixed (or any > > other excuse for not releasing soon). > > > I'd really love to see "Feature request 2918624", which I submitted on > 2009-12-21 fixed on the next release. I filed it as a feature request, > but it's kind of a bug. UTF/iso/whatever encoding looks OK on the > history pages, but on the quarantine it's all messed up. It's really > hard to read some entries like this: > > 59% Jun 7 10:18p "=?UTF-8?B?Q2FyIFdhcnJhbnR5?=" > <[email protected]> "=?UTF-8?B?RWNvbm9teSBQcm9vZiBZb3VyIENhcg==?=" > > And on the history page, > > As Innocent Tue 10:18p "Car Warranty " <[email protected]> > "Economy Proof Your Car " > ohhh boy. Such things are easy to fix. I stopped looking for the web UI long ago because so many users here where telling that they will make a new and shiny web UI in no time. So far nothing has emerged. Anyway... took me less than 5 Minutes to htmlize the from and subject line in the quarantine view. Would the attached patch (against GIT master) solve your issue? > Carlo > -- Kind Regards from Switzerland, Stevan Bajić ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Dspam-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspam-devel
2918624.patch
(application/octet-stream, 2.2 KB)
diff --git a/webui/cgi-bin/configure.pl.in b/webui/cgi-bin/configure.pl.in
index befbf10..5dc6863 100755
--- a/webui/cgi-bin/configure.pl.in
+++ b/webui/cgi-bin/configure.pl.in
@@ -1,8 +1,8 @@
#!/usr/bin/perl
-# $Id: configure.pl,v 1.05 2010/01/03 14:39:13 sbajic Exp $
+# $Id: configure.pl,v 1.06 2011/06/08 22:22:35 sbajic Exp $
# DSPAM
-# COPYRIGHT (C) DSPAM PROJECT 2002-2010
+# COPYRIGHT (C) DSPAM PROJECT 2002-2011
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
@@ -43,6 +43,7 @@ $CONFIG{'HISTORY_SIZE'} = 799; # Number of items in history
$CONFIG{'HISTORY_PER_PAGE'} = 100; # Number of items per page
$CONFIG{'HISTORY_DUPLICATES'} = "yes"; # Wether to show duplicate entries in history "yes" or "no"
$CONFIG{'HISTORY_HTMLIZE'} = "no"; # Wether to HTML-ize sender and subject in history "yes" or "no"
+$CONFIG{'QUARANTINE_HTMLIZE'} = "no"; # Wether to HTML-ize sender and subject in quarantine "yes" or "no"
$CONFIG{'MAX_COL_LEN'} = 50; # Max chars in list columns
$CONFIG{'SORT_DEFAULT'} = "Rating"; # Show quarantine by "Date" or "Rating"
$CONFIG{'3D_GRAPHS'} = 1; # 0=graphs in 2D, 1=graphs in 3D
diff --git a/webui/cgi-bin/dspam.cgi b/webui/cgi-bin/dspam.cgi
index dae53d1..156285b 100755
--- a/webui/cgi-bin/dspam.cgi
+++ b/webui/cgi-bin/dspam.cgi
@@ -1,8 +1,8 @@
#!/usr/bin/perl
-# $Id: dspam.cgi,v 1.55 2010/08/03 12:52:06 sbajic Exp $
+# $Id: dspam.cgi,v 1.56 2011/06/08 22:20:45 sbajic Exp $
# DSPAM
-# COPYRIGHT (C) DSPAM PROJECT 2002-2010
+# COPYRIGHT (C) DSPAM PROJECT 2002-2011
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
@@ -1227,6 +1227,12 @@ sub DisplayQuarantine {
if ($alert) { $rowclass="rowAlert"; }
+ # HTMLize special characters
+ if ($CONFIG{'QUARANTINE_HTMLIZE'} eq "yes") {
+ $new->{'Subject'} = htmlize($new->{'Subject'});
+ $new->{'From'} = htmlize($new->{'From'});
+ }
+
$new->{'Sub2'} = $new->{'X-DSPAM-Signature'};
if (length($new->{'Subject'})>$CONFIG{'MAX_COL_LEN'}) {
$new->{'Subject'} = substr($new->{'Subject'}, 0, $CONFIG{'MAX_COL_LEN'} - 3) . "...";