[ dspam-Bug Tracker-3055182 ] broken URLs in webui

Bug Tracker item #3055182, was opened at 2010-08-29 02:24
Message generated for change (Comment added) made by whyscream
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=3055182&group_id=250683

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: webui
>Group: v3.10.x
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: The Duck (duck207)
>Assigned to: Tom Hendrikx (whyscream)
Summary: broken URLs in webui

Initial Comment:
When you ask to display innocent mails of your history, select mails to retrain, you expect to get the same page back with your mails flaggued as retrained, but in fact you get back to the default history filter. That's boring because most people would like to just change page and retrain other mails and so on. AFAIR, it used to work well in 3.9.0, and probably early work on 3.9.1.

By reading dspam.cgi, it seems there is a mix of & and & in the URLs. I got several pages fixed with the attached patch (not sure it fixes everything).


----------------------------------------------------------------------

>Comment By: Tom Hendrikx (whyscream)
Date: 2011-08-17 00:31

Message:
I took all english templates and kept on pulling them through the w3c
validator service until all errors were gone, except for errors about some
weird encoded characters that came from an e-mail From line in the
user.log, which is not fixable within the webui itself.

I'd love to see some volunteers taking the changes and applying them to
the other language templates. The changes are in commit
82442890b84d1a421911a566bf1f821b2de57a50.

Bug is closed but comments are open, please tell us if you have some spare
time to update templates.

----------------------------------------------------------------------

Comment By: The Duck (duck207)
Date: 2010-09-29 17:01

Message:
Hello Stevan

I checked english only, but i could check french if you wish to.

I made a few minor changes to the template, like s#<br>#<br/># or
repeating the page bar on top, but nothing very intrusive, so it should not
impact on the tests.

Kind regards from DuckLand ;-)


----------------------------------------------------------------------

Comment By: Stevan Bajic (sbajic)
Date: 2010-09-29 14:34

Message:
Hello Duck,

might I ask what language you have checked with the validator? I mean what
DSPAM Web-UI language have you checked?

Kind Regards from Switzerland,

Stevan Bajic

----------------------------------------------------------------------

Comment By: The Duck (duck207)
Date: 2010-09-29 14:29

Message:
The validator did not complain for &/&amp; at all with git 6b6d8c8 and this
provided patch applied.

For the record, even if outside the scope of this issue, the validator
gave 2 errors:
* no document type declaration
* required attribute "TYPE" not specified (<script
language="javascript">)


----------------------------------------------------------------------

Comment By: Stevan Bajic (sbajic)
Date: 2010-08-29 02:53

Message:
Please check the output of the modified CGI script with the W3C validator
and tell me if that & is right or if there should be &amp; inside the HTML
documents.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=3055182&group_id=250683

------------------------------------------------------------------------------
Get a FREE DOWNLOAD! and learn more about uberSVN rich system, 
user administration capabilities and model configuration. Take 
the hassle out of deploying and managing Subversion and the 
tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2