Re: Patches from Robert Millan

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

DISCLAIMER:  I am not a libspf2 expert at all.

Magnus Holmgren wrote:
> I've tested this and indeed, calling SPF_request_set_helo_dom() but not
> SPF_request_set_env_from() gives the desired result. However, that
> approach doesn't work if one wants to reuse the same SPF_request_t for
> several queries, where the empty sender is not the first one.
>
> I suggest that this logic
>
> 	if (sr->env_from == NULL)
> 		SPF_request_set_env_from(sr, dom);
>
> be moved from SPF_request_set_helo_dom() to SPF_request_set_env_from().

But then, within SPF_request_set_env_from(), where would you get "dom" (the 
HELO domain) from?  Right, you'd use the value set by a prior call to 
SPF_request_set_helo_dom().  But then users would be required to call 
SPF_request_set_helo_dom() _first_, and SPF_request_set_env_from() 
_second_.

However, existing software may not be calling these functions in this 
order, despite <http://www.libspf2.org/docs/api.html> recommending it, and 
would thus fail.

Perhaps the above logic could be _copied_ to SPF_request_set_env_from() 
rather than _moved_?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFGrdexwL7PKlBZWjsRAnfYAJ9H7vgdiw7RssD50zxetj7NX+PejgCdH4AL
XMN7HHFL6UDTNagGK9ChDzc=
=pC3C
-----END PGP SIGNATURE-----

-------------------------------------------
-----------------------------------------------------------------------
To unsubscribe, change your address, or temporarily deactivate your
subscription,
please go to http://v2.listbox.com/member/?member_id=6959932&id_secret=26479768-24910a
Powered by Listbox: http://www.listbox.com